From owner-dev-commits-src-all@freebsd.org Thu Jan 7 23:49:49 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C5C354E0959; Thu, 7 Jan 2021 23:49:49 +0000 (UTC) (envelope-from vladimir@kondratyev.su) Received: from corp.infotel.ru (corp.infotel.ru [195.170.219.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4DBjdT47xdz4bQJ; Thu, 7 Jan 2021 23:49:49 +0000 (UTC) (envelope-from vladimir@kondratyev.su) Received: from corp (corp.infotel.ru [195.170.219.3]) by corp.infotel.ru (Postfix) with ESMTP id 12F83178C3C; Fri, 8 Jan 2021 02:49:48 +0300 (MSK) X-Virus-Scanned: amavisd-new at corp.infotel.ru Received: from corp.infotel.ru ([195.170.219.3]) by corp (corp.infotel.ru [195.170.219.3]) (amavisd-new, port 10024) with ESMTP id WF1KNA9JZgaO; Fri, 8 Jan 2021 02:49:42 +0300 (MSK) Received: from mail.cicgroup.ru (unknown [195.170.219.74]) by corp.infotel.ru (Postfix) with ESMTP id BD824178C2F; Fri, 8 Jan 2021 02:49:42 +0300 (MSK) Received: from mail.cicgroup.ru (localhost [127.0.0.1]) by mail.cicgroup.ru (Postfix) with ESMTP id 11D1242211F; Fri, 8 Jan 2021 02:49:40 +0300 (MSK) Received: from mail.cicgroup.ru ([127.0.0.1]) by mail.cicgroup.ru (mail.cicgroup.ru [127.0.0.1]) (amavisd-new, port 10024) with SMTP id UnnPMMeMc6AH; Fri, 8 Jan 2021 02:49:37 +0300 (MSK) Received: from [192.168.0.30] (gateway [10.0.2.2]) by mail.cicgroup.ru (Postfix) with ESMTPA id 9864242211C; Fri, 8 Jan 2021 02:49:37 +0300 (MSK) Subject: Re: 92cf602e3809 - main - Copy strcasestr.c from libc to libkern. To: Ravi Pokala , Jessica Clarke , Vladimir Kondratyev Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" References: <202101072320.107NKpMS063374@gitrepo.freebsd.org> <7a7fa0fb-51c2-1b14-6d37-2c400f69d7dd@kondratyev.su> <3EA011C9-2EEC-4693-B36D-69E74DF8473C@panasas.com> From: Vladimir Kondratyev Message-ID: Date: Fri, 8 Jan 2021 02:49:31 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <3EA011C9-2EEC-4693-B36D-69E74DF8473C@panasas.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4DBjdT47xdz4bQJ X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jan 2021 23:49:49 -0000 On 08.01.2021 02:41, Ravi Pokala wrote: > -----Original Message----- > From: on behalf of Vladimir Kondratyev > Date: 2021-01-07, Thursday at 15:33 > To: Jessica Clarke , Vladimir Kondratyev > Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" > Subject: Re: git: 92cf602e3809 - main - Copy strcasestr.c from libc to libkern. > > On 08.01.2021 02:27, Jessica Clarke wrote: > > On 7 Jan 2021, at 23:20, Vladimir Kondratyev wrote: > >> +#include > >> +#include > >> +#include "xlocale_private.h" > >> + > >> +/* > >> + * Find the first occurrence of find in s, ignore case. > >> + */ > >> +char * > >> +strcasestr_l(const char *s, const char *find, locale_t locale) > > > > Locales in the kernel? This feels wrong. > > > > Jess > > > > strcasestr.c was copied from userland unmodified just to allow > "git log --follow" to work. Next commit removed locale support from this > file and connected it to build. > > Unfortunately, about two-dozen commit messages from you arrived at the same time, and some were out of order; without incrementing change numbers in the subject line, figuring out the actual ordering is non-trivial. :-p > > -Ravi (rpokala@) > I hope, commit hook will be improved some day. Pushing of two-dozen commits one by one is too boring.