Date: Sun, 23 Jan 2011 13:00:25 +0000 (UTC) From: Lawrence Stewart <lstewart@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/netinet/cc cc.c Message-ID: <201101231300.p0ND0fqi086156@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
lstewart 2011-01-23 13:00:25 UTC
FreeBSD src repository
Modified files:
sys/netinet/cc cc.c
Log:
SVN rev 217748 on 2011-01-23 13:00:25Z by lstewart
An sbuf configured with SBUF_AUTOEXTEND will call malloc with M_WAITOK when a
write to the buffer causes it to overflow. We therefore can't hold the CC list
rwlock over a call to sbuf_printf() for an sbuf configured with SBUF_AUTOEXTEND.
Switch to a fixed length sbuf which should be of sufficient size except in the
very unlikely event that the sysctl is being processed as one or more new
algorithms are loaded. If that happens, we accept the race and may fail the
sysctl gracefully if there is insufficient room to print the names of all the
algorithms.
This should address a WITNESS warning and the potential panic that would occur
if the sbuf call to malloc did sleep whilst holding the CC list rwlock.
Sponsored by: FreeBSD Foundation
Reported by: Nick Hibma
Reviewed by: bz
MFC after: 3 weeks
X-MFC with: r215166
Revision Changes Path
1.7 +21 -4 src/sys/netinet/cc/cc.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201101231300.p0ND0fqi086156>