From owner-svn-src-all@FreeBSD.ORG Fri Aug 16 17:40:49 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 3E8D86EC; Fri, 16 Aug 2013 17:40:49 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qe0-x234.google.com (mail-qe0-x234.google.com [IPv6:2607:f8b0:400d:c02::234]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id AB4902690; Fri, 16 Aug 2013 17:40:48 +0000 (UTC) Received: by mail-qe0-f52.google.com with SMTP id a11so417291qen.25 for ; Fri, 16 Aug 2013 10:40:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=BQD4sNg/oJr5CseckK+XKzZWV5VlLoRQQg+8yIuvpNo=; b=v4qj4JuWPJst0E12J/9tgtgCSQeQa6hwVTU9LBkbBHXaHWpKcXU144bbnByw73OPvl 3DgKpFOVexBjSxnZrGmaQO9+lgaC8I+BOxK+OQSsql2lciuJMR7SFquYuexT+j52KBSC sRX5XQWpW4IRKjtlwhq/dPvs8PCb0SMMQcM83V/tZOR9w91josRbHToaR4lBmT4KDuH8 zSFXaH7X+OkrJKik4mrJbn9Xf3QRNXGMTVcYyBz4HiOtfKGQkPlMK7X+o5K4gX3mSdQr oURy8n2FqsIX7a9e0TE+cb5UXXC6pbeyfC8S7X7vY9JqnK4VR7vG6RBsxZPMgm32Yju/ Tn2Q== X-Received: by 10.224.114.11 with SMTP id c11mr4882651qaq.37.1376674847209; Fri, 16 Aug 2013 10:40:47 -0700 (PDT) Received: from charmander.sandvine.com ([64.7.137.182]) by mx.google.com with ESMTPSA id y1sm3266567qaj.2.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 16 Aug 2013 10:40:46 -0700 (PDT) Sender: Mark Johnston Date: Fri, 16 Aug 2013 13:41:31 -0400 From: Mark Johnston To: Davide Italiano Subject: Re: svn commit: r254309 - in head: share/man/man9 sys/cddl/contrib/opensolaris/uts/common/dtrace sys/cddl/dev/dtrace sys/cddl/dev/sdt sys/kern sys/sys Message-ID: <20130816174131.GB1888@charmander.sandvine.com> References: <201308140042.r7E0gMtf054550@svn.freebsd.org> <201308140819.13854.jhb@freebsd.org> <20130816170027.GA1888@charmander.sandvine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, John Baldwin X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2013 17:40:49 -0000 On Fri, Aug 16, 2013 at 07:13:16PM +0200, Davide Italiano wrote: > [trim old mails] > > > diff --git a/sys/sys/pmckern.h b/sys/sys/pmckern.h > > index e3e18a6..90585de 100644 > > --- a/sys/sys/pmckern.h > > +++ b/sys/sys/pmckern.h > > @@ -51,13 +51,11 @@ > > #define PMC_FN_CSW_IN 2 > > #define PMC_FN_CSW_OUT 3 > > #define PMC_FN_DO_SAMPLES 4 > > -#define PMC_FN_KLD_LOAD 5 > > -#define PMC_FN_KLD_UNLOAD 6 > > -#define PMC_FN_MMAP 7 > > -#define PMC_FN_MUNMAP 8 > > -#define PMC_FN_USER_CALLCHAIN 9 > > -#define PMC_FN_USER_CALLCHAIN_SOFT 10 > > -#define PMC_FN_SOFT_SAMPLING 11 > > +#define PMC_FN_MMAP 5 > > +#define PMC_FN_MUNMAP 6 > > +#define PMC_FN_USER_CALLCHAIN 7 > > +#define PMC_FN_USER_CALLCHAIN_SOFT 8 > > +#define PMC_FN_SOFT_SAMPLING 9 > > > > I've skimmed over your patch quickly so I could miss something, but I > worry about this change breaking the KBI. > Does this make sense for you? I think you're right. I considered this last night, but it didn't occur to me that external modules might try to invoke these hooks. I'm not sure if such modules exist, but it's better to be safe. I updated the patch here: http://people.freebsd.org/~markj/patches/hwpmc-eh/hwpmc-eh-3.diff Thanks! -Mark