From owner-freebsd-bugs@FreeBSD.ORG Sun Aug 25 19:00:00 2013 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id B5861176 for ; Sun, 25 Aug 2013 19:00:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7E9362CBC for ; Sun, 25 Aug 2013 19:00:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r7PJ00KI053805 for ; Sun, 25 Aug 2013 19:00:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r7PJ00NZ053804; Sun, 25 Aug 2013 19:00:00 GMT (envelope-from gnats) Resent-Date: Sun, 25 Aug 2013 19:00:00 GMT Resent-Message-Id: <201308251900.r7PJ00NZ053804@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Kurt Jaeger Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 69FA1EE8; Sun, 25 Aug 2013 18:51:41 +0000 (UTC) (envelope-from pi@home.opsec.eu) Received: from home.opsec.eu (home.opsec.eu [IPv6:2001:14f8:200::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 2805E2C5B; Sun, 25 Aug 2013 18:51:39 +0000 (UTC) Received: from pi by home.opsec.eu with local (Exim 4.80.1 (FreeBSD)) (envelope-from ) id 1VDfPW-000MD0-6C; Sun, 25 Aug 2013 20:51:38 +0200 Message-Id: Date: Sun, 25 Aug 2013 20:51:38 +0200 From: Kurt Jaeger To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.113 Subject: bin/181532: 'route get' without destination gives misleading error message Cc: pawel@FreeBSD.org X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Kurt Jaeger List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Aug 2013 19:00:00 -0000 >Number: 181532 >Category: bin >Synopsis: 'route get' without destination gives misleading error message >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Aug 25 19:00:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Kurt Jaeger >Release: FreeBSD 9.1-RELEASE amd64 >Organization: - >Environment: System: FreeBSD home.opsec.eu 9.1-RELEASE FreeBSD 9.1-RELEASE #0 r243825: Tue Dec 4 09:23:10 UTC 2012 root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64 >Description: If you type route get the error message is strange/misleading: route: writing to routing socket: Invalid argument The patch changes this to: route get requires a parameter, try 'default' >How-To-Repeat: route get >Fix: --- route.c 2012-12-03 19:43:01.000000000 +0100 +++ /usr/home/pi/src/route/route.c 2013-08-25 20:46:13.000000000 +0200 @@ -1229,6 +1229,11 @@ if (rtm_addrs & RTA_NETMASK) mask_addr(); + if ( so_dst.sa.sa_len == 0 && cmd == RTM_GET ) { + fprintf(stderr, + "route get requires a parameter, try 'default'\n"); + exit(1); + } NEXTADDR(RTA_DST, so_dst); NEXTADDR(RTA_GATEWAY, so_gate); NEXTADDR(RTA_NETMASK, so_mask); >Release-Note: >Audit-Trail: >Unformatted: