From owner-svn-ports-all@freebsd.org Wed Dec 13 17:46:52 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BB630E81229; Wed, 13 Dec 2017 17:46:52 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9ABCB7AAB0; Wed, 13 Dec 2017 17:46:52 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id EB4797EC8; Wed, 13 Dec 2017 17:46:51 +0000 (UTC) Date: Wed, 13 Dec 2017 17:46:51 +0000 From: Alexey Dokuchaev To: Baptiste Daroussin Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r456197 - in head/net: istgt py-beanstalkc Message-ID: <20171213174651.GA96646@FreeBSD.org> References: <201712130844.vBD8iFtf060010@repo.freebsd.org> <20171213085412.vltifyke37rwntft@ivaldir.net> <20171213090441.GA45323@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171213090441.GA45323@FreeBSD.org> User-Agent: Mutt/1.9.1 (2017-09-22) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2017 17:46:52 -0000 On Wed, Dec 13, 2017 at 09:04:41AM +0000, Alexey Dokuchaev wrote: > On Wed, Dec 13, 2017 at 09:54:12AM +0100, Baptiste Daroussin wrote: > > On Wed, Dec 13, 2017 at 08:44:15AM +0000, Alexey Dokuchaev wrote: > > > New Revision: 456197 > > > URL: https://svnweb.freebsd.org/changeset/ports/456197 > > > > > > Log: > > > Provide somewhat better option descriptions. > > > > > > Modified: > > > head/net/istgt/Makefile > > > > For this one, rather than improveing the description, you should have > > imho deprecated it, it is unmaintained, upstream is dead, and all > > supported freebsd version provides a far superior solution for iscsi > > targets via ctl(4). > > Oh, thanks for the heads-up, I'll follow up. I was just cleaning out my > ports tree from uncommitted patches accumulated over last couple of years. Looking at it more closely, we might not be quite ready to deprecate it: - `net/istgt' is explicitly mentioned in the Handbook (section 28.12.1) as an alternative to ctl(4); removing the port before the Handbook is updated would confuse the reader; [*] - It still builds fine on -CURRENT and 8.4-STABLE; as an 8.4-STABLE user, I'm not so happy to see a working port go; - I may come to peace with deprecating even on 8.4-STABLE as long as it does not allow exporting raw devices (that's what I currently do with Linux' tgtadm(8) because Linux cannot mount FreeBSD partitions, or else I'd simply exported them via NFS). File-backed storage is much less of a problem when dealing with foreign operating systems because it can always be exported via NFS, at the expense of some extra VFS calls. Can you (or anyone else) comment on these before we take any action? ./danfe [*] https://www.freebsd.org/doc/handbook/network-iscsi.html