From owner-svn-ports-head@freebsd.org Wed Oct 14 16:24:39 2020 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D84F643DB28; Wed, 14 Oct 2020 16:24:39 +0000 (UTC) (envelope-from garga.bsd@gmail.com) Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CBHn26gVpz4DNn; Wed, 14 Oct 2020 16:24:38 +0000 (UTC) (envelope-from garga.bsd@gmail.com) Received: by mail-qk1-x743.google.com with SMTP id y198so9127qka.0; Wed, 14 Oct 2020 09:24:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=J0RusQu1Lm6dK+FUNXOnul7LoD9GqxvyhLZkcR1+FtQ=; b=EPJGUVMx+gabckQUVsoaLlwy39dNCZAlwgUypRXX3Ul1yAAbhCHhChxPVLOmKC8BX7 VsmaiZbqFyrw3qalaPUl7z3N+tEPaEKjziKdtC8ZpS6wns6qct7wnXctDXQuqH1VBjRa N4fV7xxWLQpZ24Nke0nIewNxx70U6hsAUZ7XodQeec6ZKh+d1Dwrq3HlxdV2tVFhQjUt E+TcMnzZRH2vtlajs9qC0/ZRm9Ks5WMSL4LCI7aJdfaMEGTCO0Lny/ZL46SDuAXrw3B1 v+HoPv80w1HGSWjnaJn+H+Wt8QsG1KxH9VtgyfCxhoDhocOlIXH75NLA3dDTFMMkRJnK JXGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=J0RusQu1Lm6dK+FUNXOnul7LoD9GqxvyhLZkcR1+FtQ=; b=Xlw7NQmg0fhRl0OvTj1BO/4/QqqF7IRNuOaz/1m/pPRLDAvbfihkuvhAxmWeSPXipw 67+d6pdHYh9EGYDfUyWRlKbfgGiXBJFXrW1huq0ri3pn9Oh1vwLgYkMTsNGAlF1Ep7kI 58ACpmov+oaHreEsjjezui8y9sCMr0S1xVT5ceHvRj5TvzJX4/KX5A1Mma6NFEUE1nfW 6khxGHRjjbA6yKDhSO9NTBRtl07sl0XmpBLh49uZHtgT4bnxeSNs6UJrxewWU1r8TlRo 1OQ4IfyweAbWYQiZzJ8mzEffMhRz6tdoE0KJwhifZcfF0AFgUPSRcy+isioGF8p4KWkB qatQ== X-Gm-Message-State: AOAM532TYd5c4pbb5oxB58Wp0QwhsB9C2pCYdnUjom2CzN0lbsoEIXcK FMZLxeeoyrsRXHEg16GXyfJXdtel+KA= X-Google-Smtp-Source: ABdhPJyF5hUen+F6oCcLfIbkw9R7Vtsf+xpN0LNDBi0FxRrFHz+BvVwp/qtuSxqpymNH0vMcsU/9tw== X-Received: by 2002:a05:620a:4084:: with SMTP id f4mr6133288qko.449.1602692677564; Wed, 14 Oct 2020 09:24:37 -0700 (PDT) Received: from mbp.home ([177.53.82.16]) by smtp.gmail.com with ESMTPSA id v39sm1534712qtk.81.2020.10.14.09.24.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Oct 2020 09:24:36 -0700 (PDT) Sender: Renato Botelho Subject: Re: svn commit: r552232 - head/devel/git To: Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <202010131132.09DBWRIZ099906@repo.freebsd.org> <20201014115047.omi53rjydfvoabyk@aching.in.mat.cc> From: Renato Botelho Message-ID: <08277fd7-c7fe-e075-604f-bc5551626c7a@FreeBSD.org> Date: Wed, 14 Oct 2020 13:24:32 -0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: <20201014115047.omi53rjydfvoabyk@aching.in.mat.cc> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4CBHn26gVpz4DNn X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=EPJGUVMx; dmarc=none; spf=pass (mx1.freebsd.org: domain of gargabsd@gmail.com designates 2607:f8b0:4864:20::743 as permitted sender) smtp.mailfrom=gargabsd@gmail.com X-Spamd-Result: default: False [-2.49 / 15.00]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; ARC_NA(0.00)[]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_LONG(-0.98)[-0.983]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_MEDIUM(-0.98)[-0.976]; DKIM_TRACE(0.00)[gmail.com:+]; NEURAL_HAM_SHORT(-0.33)[-0.328]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::743:from]; FORGED_SENDER(0.30)[garga@FreeBSD.org,gargabsd@gmail.com]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[garga@FreeBSD.org,gargabsd@gmail.com]; MAILMAN_DEST(0.00)[svn-ports-head,svn-ports-all] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2020 16:24:39 -0000 On 14/10/20 08:50, Mathieu Arnold wrote: > On Tue, Oct 13, 2020 at 11:32:27AM +0000, Renato Botelho wrote: >> Author: garga >> Date: Tue Oct 13 11:32:26 2020 >> New Revision: 552232 >> URL: https://svnweb.freebsd.org/changeset/ports/552232 >> >> Log: >> Simplify logic to define COMMENT >> >> Submitted by: bapt >> >> Modified: >> head/devel/git/Makefile >> >> Modified: head/devel/git/Makefile >> ============================================================================== >> --- head/devel/git/Makefile Tue Oct 13 11:30:50 2020 (r552231) >> +++ head/devel/git/Makefile Tue Oct 13 11:32:26 2020 (r552232) >> @@ -12,12 +12,11 @@ EXTRACT_ONLY= ${DISTNAME}${EXTRACT_SUFX} \ >> ${PORTNAME}-manpages-${DISTVERSION}${EXTRACT_SUFX} >> >> MAINTAINER= garga@FreeBSD.org >> -.if ${FLAVOR:Udefault} == default >> COMMENT= Distributed source code management tool >> -.elif ${FLAVOR:U} == gui >> -COMMENT= Distributed source code management tool (GUI enabled flavor) >> +.if ${FLAVOR:U} == gui >> +COMMENT+= (GUI enabled flavor) >> .elif ${FLAVOR:U} == lite >> -COMMENT= Distributed source code management tool (lite flavor) >> +COMMENT+= (lite flavor) >> .endif > > If one really wanted to make it clear and simple, one could even write: > > COMMENT= Distributed source code management tool ${COMMENT_${FLAVOR}} > COMMENT_gui= (GUI enabled flavor) > COMMENT_lite= (lite flavor) Really nice! I'm going to change it. Thanks! -- Renato Botelho