From owner-svn-src-all@freebsd.org  Sat Aug  1 06:40:43 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5C1BF9AD5B5;
 Sat,  1 Aug 2015 06:40:43 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from mail110.syd.optusnet.com.au (mail110.syd.optusnet.com.au
 [211.29.132.97])
 by mx1.freebsd.org (Postfix) with ESMTP id 1637A164D;
 Sat,  1 Aug 2015 06:40:42 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from c211-30-166-197.carlnfd1.nsw.optusnet.com.au
 (c211-30-166-197.carlnfd1.nsw.optusnet.com.au [211.30.166.197])
 by mail110.syd.optusnet.com.au (Postfix) with ESMTPS id 12F2378106F;
 Sat,  1 Aug 2015 16:40:33 +1000 (AEST)
Date: Sat, 1 Aug 2015 16:40:32 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Pedro Giffuni <pfg@freebsd.org>
cc: Bruce Evans <brde@optusnet.com.au>, src-committers@freebsd.org, 
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r286102 - head/usr.bin/wall
In-Reply-To: <55BB9E9C.9030608@FreeBSD.org>
Message-ID: <20150801163923.J1074@besplex.bde.org>
References: <201507310112.t6V1CWh8034232@repo.freebsd.org>
 <20150731162408.M1843@besplex.bde.org> <55BB9E9C.9030608@FreeBSD.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Optus-CM-Score: 0
X-Optus-CM-Analysis: v=2.1 cv=eZjABOwH c=1 sm=1 tr=0
 a=KA6XNC2GZCFrdESI5ZmdjQ==:117 a=PO7r1zJSAAAA:8 a=JzwRw_2MAAAA:8
 a=kj9zAlcOel0A:10 a=v7ozDdhdh8OD8oOQhIIA:9 a=CjuIK1q_8ugA:10
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 01 Aug 2015 06:40:43 -0000

On Fri, 31 Jul 2015, Pedro Giffuni wrote:

> On 07/31/15 02:12, Bruce Evans wrote:
>> On Fri, 31 Jul 2015, Pedro F. Giffuni wrote:
>>
> ...
>
>>>     static char errbuf[1024];
>>
>> Another static buffer.  The function is obviously not reentrant.  This
>> large static buffer mainly wastes space all the time instead of only
>> when the function is called.
>
> But if I drop that static I get a bunch of errors:

Yes.  I forgot that it is is returned.  Older not so good APIs often
return a pointer to static data.

Bruce