From nobody Fri Jul 24 14:39:58 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h69d34CGQz6mDxs; Fri, 24 Jul 2026 14:40:07 +0000 (UTC) (envelope-from ronald-lists@klop.ws) Received: from smtp-relay-int.realworks.nl (smtp-relay-int.realworks.nl [31.134.205.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4h69d20LSSz3Qkt; Fri, 24 Jul 2026 14:40:05 +0000 (UTC) (envelope-from ronald-lists@klop.ws) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=klop.ws header.s=rw2 header.b=K2CHO9ny; spf=pass (mx1.freebsd.org: domain of ronald-lists@klop.ws designates 31.134.205.98 as permitted sender) smtp.mailfrom=ronald-lists@klop.ws; dmarc=pass (policy=quarantine) header.from=klop.ws Date: Fri, 24 Jul 2026 16:39:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=klop.ws; s=rw2; t=1784903998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+q6RD0/WZkt4Nuh7FvyGCnld0F6bXXz2U9FfDI0ZClU=; b=K2CHO9nySfFGy0wbX+TjshZFdgGNseWkrAeE8HR4kAeNT2dicSFwdv2hiu6MEjsDJg9jjG zpGpUqIU20yakEept85IliGQqBG9BK2d0OUTc0Nyq7YA3bFk704h4tWVBIFUDFeykzg6uo Zwxn3tWA4pdRZWvA/PsVBb4bLH8WPbUkjYAVq2Hv8Wj1Cd4SF1Znz0wXwIcIV5DA5wzu48 xGf4JhRYGvM/XTHvCu7EaX//YAJmzOUYt1pL5sQDNujFCWirOwwsCA19iEAwY1BCm0aunf 1pxfsY2ZuuxYOIbNickvYUf+LpvoQdEWuZgB6T2gIaNnumA/ePrt2uP5veEK7g== From: Ronald Klop To: Richard Scheffenegger Cc: dev-commits-src-all@FreeBSD.org, src-committers@FreeBSD.org, dev-commits-src-main@FreeBSD.org Message-ID: <1164685882.1011.1784903998087@localhost> In-Reply-To: <6a5f8e76.23f2e.57e0367f@gitrepo.freebsd.org> References: <6a5f8e76.23f2e.57e0367f@gitrepo.freebsd.org> Subject: Re: git: f22b08443f6a - main - tcp_hostcache: explicitly typecast atomic_load_int to (int) for comparison List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_1010_2101127071.1784903998053" X-Mailer: Realworks (805.141) Importance: Normal X-Priority: 3 (Normal) X-Spamd-Result: default: False [-3.39 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.990]; DMARC_POLICY_ALLOW(-0.50)[klop.ws,quarantine]; MID_RHS_NOT_FQDN(0.50)[]; R_DKIM_ALLOW(-0.20)[klop.ws:s=rw2]; R_SPF_ALLOW(-0.20)[+ip4:31.134.205.64/26]; ONCE_RECEIVED(0.10)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TO_DN_SOME(0.00)[]; ASN(0.00)[asn:51088, ipnet:31.134.200.0/21, country:NL]; RCVD_COUNT_ZERO(0.00)[0]; MLMMJ_DEST(0.00)[dev-commits-src-all@FreeBSD.org,dev-commits-src-main@FreeBSD.org]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; HAS_X_PRIO_THREE(0.00)[3]; DKIM_TRACE(0.00)[klop.ws:+] X-Rspamd-Queue-Id: 4h69d20LSSz3Qkt X-Spamd-Bar: --- ------=_Part_1010_2101127071.1784903998053 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Hi, This commit message is telling *what* the diff changes. And is a bit redundant in that sense. I was surprised that the linked review has a very nice explanation of *why* this change was needed. I think it will be very valuable to future commit readers to include the *why* in the commit message. The *why* in the message, the *what* is already in the diff. Regards, Ronald. Van: Richard Scheffenegger Datum: dinsdag, 21 juli 2026 17:21 Aan: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Onderwerp: git: f22b08443f6a - main - tcp_hostcache: explicitly typecast atomic_load_int to (int) for comparison > > The branch main has been updated by rscheff: > > URL: https://cgit.FreeBSD.org/src/commit/?id=f22b08443f6ae3620dd14ade4e2376b8531fd6f3 > > commit f22b08443f6ae3620dd14ade4e2376b8531fd6f3 > Author: Richard Scheffenegger > AuthorDate: 2026-07-21 14:51:02 +0000 > Commit: Richard Scheffenegger > CommitDate: 2026-07-21 15:20:32 +0000 > > tcp_hostcache: explicitly typecast atomic_load_int to (int) for comparison > > Sponsored by: NetApp, Inc. > MFC after: 1 week > Reviewed By: tuexen, #transport, markj > Differential Revision: https://reviews.freebsd.org/D58360 > --- > sys/netinet/tcp_hostcache.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sys/netinet/tcp_hostcache.c b/sys/netinet/tcp_hostcache.c > index e5c20b6f2475..fbf81b1f2303 100644 > --- a/sys/netinet/tcp_hostcache.c > +++ b/sys/netinet/tcp_hostcache.c > @@ -768,7 +768,7 @@ tcp_hc_purge_internal(int all) > "bucket length out of range at %u: %u", i, > head->hch_length)); > if (all || > - atomic_load_int(&hc_entry->hc_expire) <= 0) { > + (int)atomic_load_int(&hc_entry->hc_expire) <= 0) { > if (hc_prev != NULL) { > KASSERT(hc_entry == > CK_SLIST_NEXT(hc_prev, hc_q), > > > > ------=_Part_1010_2101127071.1784903998053 Content-Type: text/html; charset=us-ascii Content-Transfer-Encoding: 7bit Hi,

This commit message is telling *what* the diff changes. And is a bit redundant in that sense.

I was surprised that the linked review has a very nice explanation of *why* this change was needed.

I think it will be very valuable to future commit readers to include the *why* in the commit message. The *why* in the message, the *what* is already in the diff.

Regards,
Ronald.

 

Van: Richard Scheffenegger <rscheff@FreeBSD.org>
Datum: dinsdag, 21 juli 2026 17:21
Aan: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Onderwerp: git: f22b08443f6a - main - tcp_hostcache: explicitly typecast atomic_load_int to (int) for comparison

The branch main has been updated by rscheff:

URL: https://cgit.FreeBSD.org/src/commit/?id=f22b08443f6ae3620dd14ade4e2376b8531fd6f3

commit f22b08443f6ae3620dd14ade4e2376b8531fd6f3
Author:     Richard Scheffenegger <rscheff@FreeBSD.org>
AuthorDate: 2026-07-21 14:51:02 +0000
Commit:     Richard Scheffenegger <rscheff@FreeBSD.org>
CommitDate: 2026-07-21 15:20:32 +0000

    tcp_hostcache: explicitly typecast atomic_load_int to (int) for comparison
    
    Sponsored by:   NetApp, Inc.
    MFC after:      1 week
    Reviewed By:    tuexen, #transport, markj
    Differential Revision: https://reviews.freebsd.org/D58360
---
 sys/netinet/tcp_hostcache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/netinet/tcp_hostcache.c b/sys/netinet/tcp_hostcache.c
index e5c20b6f2475..fbf81b1f2303 100644
--- a/sys/netinet/tcp_hostcache.c
+++ b/sys/netinet/tcp_hostcache.c
@@ -768,7 +768,7 @@ tcp_hc_purge_internal(int all)
                "bucket length out of range at %u: %u", i,
                head->hch_length));
            if (all ||
-               atomic_load_int(&hc_entry->hc_expire) <= 0) {
+               (int)atomic_load_int(&hc_entry->hc_expire) <= 0) {
                if (hc_prev != NULL) {
                    KASSERT(hc_entry ==
                        CK_SLIST_NEXT(hc_prev, hc_q),
 

  ------=_Part_1010_2101127071.1784903998053--