From owner-freebsd-current@FreeBSD.ORG Thu Feb 1 07:31:43 2007 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BD97A16A401 for ; Thu, 1 Feb 2007 07:31:43 +0000 (UTC) (envelope-from youshi10@u.washington.edu) Received: from mxout4.cac.washington.edu (mxout4.cac.washington.edu [140.142.33.19]) by mx1.freebsd.org (Postfix) with ESMTP id 9A15413C441 for ; Thu, 1 Feb 2007 07:31:43 +0000 (UTC) (envelope-from youshi10@u.washington.edu) Received: from smtp.washington.edu (smtp.washington.edu [140.142.32.141] (may be forged)) by mxout4.cac.washington.edu (8.13.7+UW06.06/8.13.7+UW06.09) with ESMTP id l117VhiF005921 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 31 Jan 2007 23:31:43 -0800 X-Auth-Received: from [192.168.10.41] (c-67-187-172-183.hsd1.ca.comcast.net [67.187.172.183]) (authenticated authid=youshi10) by smtp.washington.edu (8.13.7+UW06.06/8.13.7+UW06.09) with ESMTP id l117VgGx011193 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Wed, 31 Jan 2007 23:31:42 -0800 Message-ID: <45C19758.8070704@u.washington.edu> Date: Wed, 31 Jan 2007 23:31:36 -0800 From: Garrett Cooper User-Agent: Thunderbird 1.5.0.9 (X11/20070122) MIME-Version: 1.0 To: freebsd-current@freebsd.org References: <20070201002623.b8cb5d08.ota@j.email.ne.jp> In-Reply-To: <20070201002623.b8cb5d08.ota@j.email.ne.jp> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-PMX-Version: 5.3.0.289146, Antispam-Engine: 2.5.0.283055, Antispam-Data: 2007.1.31.231932 X-Uwash-Spam: Gauge=IIIIIII, Probability=7%, Report='__CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __HAS_MSGID 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __SANE_MSGID 0, __USER_AGENT 0' Subject: Re: [patch] mount fails to call external programs X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Feb 2007 07:31:43 -0000 Yoshihiro Ota wrote: > Hello. > > The 'mount' program attempts to maintain external mount programs in order to determine whether it needs to call external programs or handle it internally. > > Not all external programs can be listed in mount.c. Indeed, my mount_md failed after mount trying to handle it itself. > > The solution is to maintain interally handlable fs types. > > I am not fully sure if I listed all of them correctly; however, it fixes the problem. > > Thanks, > Hiro > > > ------------------------------------------------------------------------ > > Index: mount.c > =================================================================== > RCS file: /home/ncvs/src/sbin/mount/mount.c,v > retrieving revision 1.92 > diff -u -r1.92 mount.c > --- mount.c 14 Nov 2006 01:07:42 -0000 1.92 > +++ mount.c 1 Feb 2007 05:25:55 -0000 > @@ -133,18 +133,19 @@ > */ > unsigned int i; > const char *fs[] = { > - "cd9660", "mfs", "msdosfs", "nfs", "nfs4", "ntfs", > - "nwfs", "nullfs", "portalfs", "smbfs", "udf", "umapfs", > - "unionfs", > + "ufs", > + "ext2fs", > + "devfs", "fdescfs", "procfs", "linprocfs", "linsysfs", > + "std", > NULL > }; > > for (i = 0; fs[i] != NULL; ++i) { > if (strcmp(vfstype, fs[i]) == 0) > - return (1); > + return (0); > } > > - return (0); > + return (1); > } > > static int > > > ------------------------------------------------------------------------ Unfortunately your patch voids the point of having the filesystems listed there, according to the author of the comment directly above structure you have shown. I honestly don't know why anyone would want to statically define that though, because mount_* searching in $PATH should suffice, and the nmount interface could be maintained in each sourcefile. Just my thoughts on the subject though.. -Garrett