Date: Thu, 21 Dec 2017 11:50:27 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Marius Strobl <marius@FreeBSD.org>, Ian Lepore <ian@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r327053 - head/sys/sparc64/include Message-ID: <20171221095027.GN12785@kib.kiev.ua> In-Reply-To: <201712210127.vBL1RXFC046423@repo.freebsd.org> References: <201712210127.vBL1RXFC046423@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Dec 21, 2017 at 01:27:33AM +0000, Marius Strobl wrote: > Author: marius > Date: Thu Dec 21 01:27:32 2017 > New Revision: 327053 > URL: https://svnweb.freebsd.org/changeset/base/327053 > > Log: > Remove MD atomic_load_{32,64,int,long,ptr}(9) obsolete since the addition > of (conflicting) MI ones in r326971. I am sorry. Initially I wrote the patch with only support for required MI types int long ptr and run the tinderbox. Then I decided that there is no reason to not provide the rest, but did not realized that tb is needed again. > > Modified: > head/sys/sparc64/include/atomic.h > > Modified: head/sys/sparc64/include/atomic.h > ============================================================================== > --- head/sys/sparc64/include/atomic.h Thu Dec 21 01:22:36 2017 (r327052) > +++ head/sys/sparc64/include/atomic.h Thu Dec 21 01:27:32 2017 (r327053) > @@ -258,11 +258,6 @@ atomic_fcmpset_rel_ ## name(volatile ptype p, vtype *e > } \ > \ > static __inline vtype \ > -atomic_load_ ## name(volatile ptype p) \ > -{ \ > - return ((vtype)atomic_cas((p), 0, 0, sz)); \ atomic_cas() does not have any barrier behavior, am I right ? I.e., it does not prevent a reordering in RMO and PSO models. > -} \ > -static __inline vtype \ > atomic_load_acq_ ## name(volatile ptype p) \ > { \ > return ((vtype)atomic_cas_acq((p), 0, 0, sz)); \
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171221095027.GN12785>