From owner-cvs-sys Tue Aug 8 05:53:14 1995 Return-Path: cvs-sys-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.11/8.6.6) id FAA27253 for cvs-sys-outgoing; Tue, 8 Aug 1995 05:53:14 -0700 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.cdrom.com (8.6.11/8.6.6) with ESMTP id FAA27246 ; Tue, 8 Aug 1995 05:53:06 -0700 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id WAA08529; Tue, 8 Aug 1995 22:48:57 +1000 Date: Tue, 8 Aug 1995 22:48:57 +1000 From: Bruce Evans Message-Id: <199508081248.WAA08529@godzilla.zeta.org.au> To: bde@zeta.org.au, jkh@time.cdrom.com Subject: Re: cvs commit: src/sys/i386/isa syscons.c Cc: CVS-commiters@freefall.cdrom.com, cvs-sys@freefall.cdrom.com, dyson@freefall.cdrom.com Sender: cvs-sys-owner@freebsd.org Precedence: bulk >> Actually it isn't really OK to simply substitute M_NOWAIT with M_WAITOK. >Argh. Perhaps I was too hasty. If John decides to rearchitect this, >I'll pull it out of 2.1 It has a lot of company. I looked at all the isa drivers that use M_WAITOK and there seems to be a problem in them all. Some of them bogusly check whether the waiting malloc() returns 0 and could probably be fixed easily by switching to a non-waiting malloc(). There aren't many isa drivers with the problem so fixing it should be manageable especially if it is acceptable for open() to return ENOMEM. Bruce