Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 8 Aug 1995 22:48:57 +1000
From:      Bruce Evans <bde@zeta.org.au>
To:        bde@zeta.org.au, jkh@time.cdrom.com
Cc:        CVS-commiters@freefall.cdrom.com, cvs-sys@freefall.cdrom.com, dyson@freefall.cdrom.com
Subject:   Re: cvs commit: src/sys/i386/isa syscons.c
Message-ID:  <199508081248.WAA08529@godzilla.zeta.org.au>

next in thread | raw e-mail | index | archive | help
>> Actually it isn't really OK to simply substitute M_NOWAIT with M_WAITOK.

>Argh.  Perhaps I was too hasty.  If John decides to rearchitect this,
>I'll pull it out of 2.1

It has a lot of company.  I looked at all the isa drivers that use M_WAITOK
and there seems to be a problem in them all.  Some of them bogusly check
whether the waiting malloc() returns 0 and could probably be fixed easily
by switching to a non-waiting malloc().  There aren't many isa drivers
with the problem so fixing it should be manageable especially if it is
acceptable for open() to return ENOMEM.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199508081248.WAA08529>