From owner-freebsd-ports@FreeBSD.ORG Wed Nov 19 00:07:14 2014 Return-Path: Delivered-To: ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 81DEBE6C for ; Wed, 19 Nov 2014 00:07:14 +0000 (UTC) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "funkthat.com", Issuer "funkthat.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4552E912 for ; Wed, 19 Nov 2014 00:07:13 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id sAJ07CaS068300 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 18 Nov 2014 16:07:13 -0800 (PST) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id sAJ07Cbx068299 for ports@FreeBSD.org; Tue, 18 Nov 2014 16:07:12 -0800 (PST) (envelope-from jmg) Date: Tue, 18 Nov 2014 16:07:12 -0800 From: John-Mark Gurney To: ports@FreeBSD.org Subject: Re: help w/ port just installing files... Message-ID: <20141119000712.GL24601@funkthat.com> Mail-Followup-To: John-Mark Gurney , ports@FreeBSD.org References: <20141118033110.GX24601@funkthat.com> <20141118203522.GE24601@funkthat.com> <20141118204225.GF24601@funkthat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141118204225.GF24601@funkthat.com> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Tue, 18 Nov 2014 16:07:13 -0800 (PST) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Nov 2014 00:07:14 -0000 John-Mark Gurney wrote this message on Tue, Nov 18, 2014 at 12:42 -0800: > John-Mark Gurney wrote this message on Tue, Nov 18, 2014 at 12:35 -0800: > > John-Mark Gurney wrote this message on Mon, Nov 17, 2014 at 19:31 -0800: > > > So, I'm trying to get a port that will install the NIST's KAT vectors > > > so I can write a test program using them... > > > > Ok, so here is a port I'm submitting for reivew so that I can commit it. > > Oops, forgot to run portlist -A on it before submitting... I've fixed > the direct use of chmod, mkdir and cp... I moved the MASTER_SITES and > DISTFILES to the earlier section... > > Now portlint only says: > WARN: Makefile: [25]: possible use of "${CHMOD}" found. Use @owner/@group operators in pkg-plist instead. > FATAL: Makefile: extra item "BASE_URL" placed in the PORTNAME section. > WARN: Makefile: Consider defining LICENSE. > > I can't do much about the CHMOD warning as that is necessary unless we > want world writable files installed by the package... > > I could move BASE_URL to after the COMMENT, and it would work (because > make), but I find that less that readable... > > Attached is the new Makefile... Sorry for the constant emails, learning new things as I go... > # We want each dist file in it's own subdir > EXTRACT_CMD= ${MKDIR} ${PORTNAME}/$${file%.zip} && ${TAR} > EXTRACT_AFTER_ARGS=-C ${PORTNAME}/$${file%.zip} && \ > ${CHMOD} -R a-w ${PORTNAME}/$${file%.zip} With the below change, this simply drops the CHMOD to be: EXTRACT_AFTER_ARGS=-C ${PORTNAME}/$${file%.zip} [...] > do-install: > ${MKDIR} ${STAGEDIR}${LOCALBASE}/share && \ > ${CP} -Rp ${WRKSRC}/${PORTNAME} ${STAGEDIR}${LOCALBASE}/share Is now: do-install: ${MKDIR} ${STAGEDIR}${LOCALBASE}/share && \ (cd ${WRKSRC}/${PORTNAME} && ${COPYTREE_SHARE} . ${STAGEDIR}${DATADIR}) so that proper ownership and modes are automaticly applied... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."