From owner-cvs-all Sat Nov 16 19:40:43 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E678137B401; Sat, 16 Nov 2002 19:40:41 -0800 (PST) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9FE3C43E42; Sat, 16 Nov 2002 19:40:41 -0800 (PST) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 7E373AE2E4; Sat, 16 Nov 2002 19:40:41 -0800 (PST) Date: Sat, 16 Nov 2002 19:40:41 -0800 From: Alfred Perlstein To: Garrett Wollman Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/gen sysconf.c Message-ID: <20021117034041.GC6882@elvis.mu.org> References: <200211160635.gAG6ZKUX094649@repoman.freebsd.org> <200211160706.gAG76Z4S089556@khavrinen.lcs.mit.edu> <20021116095822.GT50692@elvis.mu.org> <200211170202.gAH22oLd099179@khavrinen.lcs.mit.edu> <20021117030805.GA6882@elvis.mu.org> <200211170333.gAH3XG7o099552@khavrinen.lcs.mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200211170333.gAH3XG7o099552@khavrinen.lcs.mit.edu> User-Agent: Mutt/1.4i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Garrett Wollman [021116 19:33] wrote: > < said: > > > In re 1.18, the problem is that the code changes a 0 return to -1, > > at least for _SC_AIO_PRIO_DELTA_MAX, so that portion of the revision > > should stay right? (since 0 is a valid response from the kernel) > > The bug here is that these cases are going through the `yesno' logic > but are not booleans. Replace the `goto yesno' with `break' and the > Right Thing should happen (i.e., the value from the kernel will be > returned). > > -GAWollman But don't we want -1 for _SC_AIO_LISTIO_MAX and _SC_AIO_MAX when it's not loaded? -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message