From owner-cvs-all@FreeBSD.ORG  Fri Aug 27 04:38:59 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id DFF1316A4CE; Fri, 27 Aug 2004 04:38:59 +0000 (GMT)
Received: from ylpvm29.prodigy.net (ylpvm29-ext.prodigy.net [207.115.57.60])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id A269543D48; Fri, 27 Aug 2004 04:38:59 +0000 (GMT)
	(envelope-from kris@obsecurity.org)
Received: from obsecurity.dyndns.org
	(adsl-63-207-60-253.dsl.lsan03.pacbell.net [63.207.60.253])
	i7R4cpNW029685;	Fri, 27 Aug 2004 00:38:51 -0400
Received: by obsecurity.dyndns.org (Postfix, from userid 1000)
	id ED636511EB; Thu, 26 Aug 2004 21:38:57 -0700 (PDT)
Date: Thu, 26 Aug 2004 21:38:57 -0700
From: Kris Kennaway <kris@obsecurity.org>
To: "David E. O'Brien" <obrien@FreeBSD.org>
Message-ID: <20040827043857.GA16903@xor.obsecurity.org>
References: <200408270116.i7R1GmiF036802@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="Dxnq1zWXvFF0Q93v"
Content-Disposition: inline
In-Reply-To: <200408270116.i7R1GmiF036802@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
cc: cvs-ports@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/devel/gettext Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Aug 2004 04:39:00 -0000


--Dxnq1zWXvFF0Q93v
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 27, 2004 at 01:16:48AM +0000, David E. O'Brien wrote:
> obrien      2004-08-27 01:16:48 UTC
>=20
>   FreeBSD ports repository
>=20
>   Modified files:
>     devel/gettext        Makefile=20
>   Log:
>   Add a NO_GETTEXT_OPTIONS knob.

Several points:

1) You also silently removed the dependency on expat.

2) User control knobs of this nature must be in the WITH_*/WITHOUT_*
namespace, not NO_*.

3) This duplicates what BATCH does, as we discussed about a month ago.

Kris
--Dxnq1zWXvFF0Q93v
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (FreeBSD)

iD8DBQFBLrrhWry0BWjoQKURApaBAJ9N3iN5IfmNxO/JicqMvlL0dGrDqgCeJ9Pv
Flr0dBeYFXgoxPXgKTEmwPQ=
=p6lI
-----END PGP SIGNATURE-----

--Dxnq1zWXvFF0Q93v--