From owner-freebsd-current Mon Jan 21 5:12:13 2002 Delivered-To: freebsd-current@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id 64FFC37B416 for ; Mon, 21 Jan 2002 05:12:03 -0800 (PST) Received: (from ache@localhost) by nagual.pp.ru (8.11.6/8.11.6) id g0LDBfq35445; Mon, 21 Jan 2002 16:11:42 +0300 (MSK) (envelope-from ache) Date: Mon, 21 Jan 2002 16:11:40 +0300 From: "Andrey A. Chernov" To: Dag-Erling Smorgrav Cc: Mark Murray , current@FreeBSD.ORG Subject: Re: Step5, pam_opie OPIE auth fix for review Message-ID: <20020121131139.GA35330@nagual.pp.ru> References: <20020120233050.GA26913@nagual.pp.ru> <20020121000446.GB27206@nagual.pp.ru> <20020121002557.GB27831@nagual.pp.ru> <20020121004906.GA28231@nagual.pp.ru> <20020121025009.GA30673@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.24i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Jan 21, 2002 at 13:54:29 +0100, Dag-Erling Smorgrav wrote: > > Umm, you can't use opiechallenge() for that. You're not supposed to > call opiechallenge() without also calling opieverify() (plus, I think No, it is possible, when opieunlock() called afterwards (as I do). BTW, the same way pam_opie does, see opieunlock() inside prompts loop. > opiechallenge() "consumes" a challenge). No, it is opieverify() who consumes it. You can call opiechallenge() several times with appropriate opieunlock()'s and challenge will not changed. In fact our ftpd does it, first opiechallenge() called to generate prompt in the form pam_opie can't generate and the second is opiechallenge() called from pam_opie (invisible). > Use opielookup() instead. Ok. It will be faster then opiechallenge() for this case. I'll send modified patch. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message