Date: Tue, 8 Mar 2016 16:52:17 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Pietro Cerutti <gahr@gahr.ch> Cc: Mathieu Arnold <mat@freebsd.org>, wenheping <wenheping2000@hotmail.com>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, owner-ports-committers@freebsd.org Subject: Re: svn commit: r410453 - in head/math/fityk: . files Message-ID: <20160308165217.GA50159@FreeBSD.org> In-Reply-To: <d90fdb7ea886d2ff2da13739a913a2b1@gahr.ch> References: <BLU168-W101BAF80F561B4B29A45AAAACB20@phx.gbl> <E5010340890C09BE8EF68750@ogg.in.absolight.net> <d90fdb7ea886d2ff2da13739a913a2b1@gahr.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 08, 2016 at 04:06:59PM +0100, Pietro Cerutti wrote: > So, danfe@, would you mind explaining to me on which basis muting MKDIRs > is "at one's discretion" while muting INSTALLs is "actually wrong"? It was discussed a number of times in the past, so short answer would be "search the archives", but a longer version isn't much longer actually. Muting mkdir's tradition goes far back in the past: I recall seeing it back in early 2000's when I first started to use/hack on ports. I guess it makes sense, since it typically precedes installation command(s), thus making the build log more verbose for little gain (the last argument is the same). Some people go even further by not trusting that mkdir would succeed, and append trailing slash to install/cp/whatever. While it looks ugly, it does prevent silent installation as file rather in destination directory, thus making "should we echo mkdir's" even less of a question. These days, I would say it's a matter of style (and thus use "at one's discretion" phrase) because typically installation bugs would be caught by tinderbox/p*re runs and `make check-plist' target. That said, I disagree with https://reviews.freebsd.org/D5581 in the place where it's forcing vocalizing of mkdir's. It's not that big deal to tell people how to do it, and proposal does not give enough (or any, I'd say) rationale to back up this claim: basically it's just because mat@ does not like them. :) We're often told not to enforce our personal preferences on others, yet this is exactly how it looks right now, sorry Mathieu. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160308165217.GA50159>