From owner-freebsd-net@FreeBSD.ORG  Tue Apr  1 20:20:17 2008
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 53505106564A
	for <freebsd-net@freebsd.org>; Tue,  1 Apr 2008 20:20:17 +0000 (UTC)
	(envelope-from rpaulo@gmail.com)
Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.156])
	by mx1.freebsd.org (Postfix) with ESMTP id CFB068FC15
	for <freebsd-net@freebsd.org>; Tue,  1 Apr 2008 20:20:16 +0000 (UTC)
	(envelope-from rpaulo@gmail.com)
Received: by fg-out-1718.google.com with SMTP id 16so2342356fgg.35
	for <freebsd-net@freebsd.org>; Tue, 01 Apr 2008 13:20:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta;
	h=domainkey-signature:received:received:date:from:to:cc:subject:message-id:references:mime-version:content-type:content-disposition:in-reply-to:user-agent:sender;
	bh=fQ0gaspDDR6SOmA0HIaOI6GEVQUCmPw5lQK4b00rjkk=;
	b=NSSkWdHxUHlpxHiW5Q3rs0XFkw/pUttFILANdmu5kJWtOfNf7qKfgWdisdA19RoXB2fA5Ltmjr062VvYMtQZ5O2VfvVR3dtwKNkyIeec04BAryZS+DiFxz3kFV58ZCoV0qllEzuNcUlsNWekALpDjjcAO7PW6KAcNlGgpp8eAvY=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta;
	h=date:from:to:cc:subject:message-id:references:mime-version:content-type:content-disposition:in-reply-to:user-agent:sender;
	b=iBRqxqTqMsgcXf3iR6kQdUGZoTpVmSiWccqkidtZDEYfTmnLEOEzVV+4X7V0xR58ZiZhxQRLw6lE2LQNT/ujfKht97lBdneBmP/UZscleqzJGQQ4z/7FGVHYL9ehjLsumCy+jsh9u+PrckPkhofb45dHCYnBDDKbxRpKg5GsR54=
Received: by 10.86.82.16 with SMTP id f16mr5665088fgb.60.1207081213942;
	Tue, 01 Apr 2008 13:20:13 -0700 (PDT)
Received: from fnop.net ( [89.214.179.125])
	by mx.google.com with ESMTPS id 4sm383961fge.3.2008.04.01.13.20.11
	(version=SSLv3 cipher=OTHER); Tue, 01 Apr 2008 13:20:13 -0700 (PDT)
Date: Tue, 1 Apr 2008 21:20:05 +0100
From: Rui Paulo <rpaulo@fnop.net>
To: Andre Oppermann <andre@freebsd.org>
Message-ID: <20080401202005.GB1491@fnop.net>
References: <fstmm9$oci$1@ger.gmane.org> <20080401191246.GA1491@fnop.net>
	<fsu2c6$6iv$1@ger.gmane.org> <47F29471.10901@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <47F29471.10901@freebsd.org>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: Rui Paulo <rpaulo@gmail.com>
Cc: freebsd-net@freebsd.org, rpaulo@freebsd.org,
	Mark Atkinson <atkin901@yahoo.com>
Subject: Re: panic: tcp_addoptions: TCP options too long w/ with
	TCP_SIGNATURE support
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Apr 2008 20:20:17 -0000

On Tue, Apr 01, 2008 at 10:00:49PM +0200, Andre Oppermann wrote:
> 
> The order of the TCP options was changed recently to fix another problem.
> This has caused sub-optimal padding and this overflow as not all options
> fit.  The tcp_addoptions() loop is not bound internally.
> 
> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/netinet/tcp_output.c?rev=1.146

Hmm. Are you sure you wanted to show this revision ?
There's not change for optlen because TCPOLEN_NOP == 1, I think.

-- 
Rui Paulo