From owner-cvs-sbin Mon Mar 3 02:07:17 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id CAA18975 for cvs-sbin-outgoing; Mon, 3 Mar 1997 02:07:17 -0800 (PST) Received: from rover.village.org (rover.village.org [204.144.255.49]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id BAA18629; Mon, 3 Mar 1997 01:58:58 -0800 (PST) Received: from rover.village.org [127.0.0.1] by rover.village.org with esmtp (Exim 0.56 #1) id E0w1UWG-0006aO-00; Mon, 3 Mar 1997 02:58:56 -0700 Subject: Re: cvs commit: src/sbin/ping ping.c Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org In-reply-to: Your message of "Mon, 03 Mar 1997 01:44:20 PST." <199703030944.BAA17164@freefall.freebsd.org> References: <199703030944.BAA17164@freefall.freebsd.org> Date: Mon, 03 Mar 1997 02:58:56 -0700 From: Warner Losh Message-Id: Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk In message <199703030944.BAA17164@freefall.freebsd.org> Warner Losh writes: : imp 97/03/03 01:44:20 : : Modified: sbin/ping ping.c : Log: : Backport changes from current: : 1) getopt returnes -1 and remove 'h:' that isn't needed : 2) -l needs super user now to work : 3) check to make sure that address returned from gethostbyname will fit in : sin_addr : 4) Fix minor strncpy bug. : 5) Don't leak information about ICMP packets that aren't for you, unless : superuser. : : Revision Changes Path : 1.8.2.8 +12 -3 src/sbin/ping/ping.c Unless there are problems found with this, I'd like to merge it into the 2.1 branch. At least those parts that drop in easily, I'm not sure about #5. Also, the 2.1 branch should have other changes merged as well (specifically the setuid(getuid()) change and some of the -Q chanage that #5 depends on). Can anybody (besides Guido who is already look at it) review this? Warner