From owner-svn-ports-head@freebsd.org Wed Feb 10 15:46:13 2021 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 49EE754A3A1; Wed, 10 Feb 2021 15:46:13 +0000 (UTC) (envelope-from jrm@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DbPHn1fNfz4dVK; Wed, 10 Feb 2021 15:46:13 +0000 (UTC) (envelope-from jrm@freebsd.org) Received: from phe.ftfl.ca.ftfl.ca (drmons0544w-156-34-166-54.dhcp-dynamic.fibreop.ns.bellaliant.net [156.34.166.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: jrm/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id D07C4D212; Wed, 10 Feb 2021 15:46:12 +0000 (UTC) (envelope-from jrm@freebsd.org) From: Joseph Mingrone To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r564803 - in head/sysutils: . rmlint rmlint/files References: <202102091926.119JQQL8050604@repo.freebsd.org> <20210210023501.GA65146@FreeBSD.org> Date: Wed, 10 Feb 2021 11:46:11 -0400 In-Reply-To: <20210210023501.GA65146@FreeBSD.org> (Alexey Dokuchaev's message of "Wed, 10 Feb 2021 02:35:01 +0000") Message-ID: <868s7wlyd8.fsf@phe.ftfl.ca> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2021 15:46:13 -0000 --=-=-= Content-Type: text/plain On Wed, 2021-02-10 at 02:35, Alexey Dokuchaev wrote: > On Tue, Feb 09, 2021 at 07:26:26PM +0000, Joseph Mingrone wrote: >> New Revision: 564803 >> URL: https://svnweb.freebsd.org/changeset/ports/564803 >> Log: >> New port, sysutils/rmlint: Remove duplicates from your filesystem > Hi Joseph, > I'm afraid this was not sufficiently reviewed, there are number of > issues with this port, I'll comment on the more serious ones. All should be fixed in r564864. There was a long gap between when I first looked at this submission and when I committed. I thought that I had reviewed it more closely, but apparently not. When it passed build and run tests, I committed too quickly. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKkBAEBCgCOFiEEVbCTpybDiFVxIrrVNqQMg7DW754FAmAj/8NfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU1 QjA5M0E3MjZDMzg4NTU3MTIyQkFENTM2QTQwQzgzQjBENkVGOUUQHGpybUBmcmVl YnNkLm9yZwAKCRA2pAyDsNbvnqpRD/4lPsql3q8lBN7Fi4fn7JBwwMTTkhHtX5Uk /WBf6ogpF5+HXIi3uvKcJK1Ja1gHMKLmP7bYm14Pk/7RLqSSl92fWwdML1dJOXQA kp8FQLuFm87yzmtjlV8li3tmK+B4i1TiEkpYnc7IHIFlqWsPSB0GLeUeLISvZE1k 9f+U3D+FbRmcBaTSuiL95hQT6268GRuUdgCwqZhw01DzVqHaWbv1v8tzlJDOhOTR 21RnbMh0qji8zEmFh6HHnUCqop+9Uq2/0TI7LXLbya0pg5P8RsFXZIO8KJt8uAgn 8KRSOIZEU+EIx601UFZEdPjdLkRs+0DBgaqgm9wB/+XJ56JhMAJ89xzf8Xjclj7U CvTA8ElqkfDeqIOJRYUU2wmFOgZNrQUhjFWNvQV/MPQKXhfbkmD2SfhFjitXDZi/ dTrp28L0LuBzVRf5naXrGMZL6t8a6NPMXvW/mIXgcmQBkXVOoUFuSa7HnXVvE0zS MKacvpoMj72tFowvhzSsribcsjTXrYFVqdsufOt+Uo1wukYHflXOTEMRk/byQA6p nBOPEiEcKXyjpn0IXZtFEnRalissLO3YNtphjOVqTDkXsCaAlUL23MgFeWM01P4Q LbIsjcLiYq/dhi8JPETlgJTjJ1UQgWCHGw7TgiE4bm2bIDCYd2AB80TMLwDdmrDI L4boIDf6YA== =zjU+ -----END PGP SIGNATURE----- --=-=-=--