From nobody Fri Jun 30 21:05:52 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qt7Ck3VPLz4l1CK; Fri, 30 Jun 2023 21:06:26 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.pphosted.com", Issuer "Thawte RSA CA 2018" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qt7Ck0mLHz3nFF; Fri, 30 Jun 2023 21:06:26 +0000 (UTC) (envelope-from sjg@juniper.net) Authentication-Results: mx1.freebsd.org; none Received: from pps.filterd (m0108163.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35UJfTnV004315; Fri, 30 Jun 2023 14:06:24 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=to : cc : subject : in-reply-to : references : from : mime-version : content-type : content-id : date : message-id; s=PPS1017; bh=DVx8LZnEAFrVBJKppWt5JNMkoo0H9jeTToaygWHo/ds=; b=sN/yWG9o79dl7SfIS3DCthrdyi4h9evrx779kUh2r0uAgfkvUujIdFTlDvMPmevq5J3x 7wcDnOph/7jJ9SGKFaBRTBb5QLN3dqYGASkwAXnFqLGl3N1yal21A9OQ/XDCcC1f8vta 3oJONZt5Dc+B/CDw9cN3RqXct7le3ol0Zgb2GINj8IMuOyLDNqlQkeUpNpMgm691S6x/ 9n1lKOvDx/bG+KTprBedbbvS/PVbeI0n/O1wuGeLP8/Brof679akWV5shPBa7dROGEvG 5B5XkSoCQAFjH47K4H97e3812vOy9JOo9ViGmq8jiHtNoFxy6mT1tYMVeJubaQjzDtm/ wQ== Received: from dm4pr02cu001.outbound.protection.outlook.com (mail-centralusazlp17012021.outbound.protection.outlook.com [40.93.13.21]) by mx0b-00273201.pphosted.com (PPS) with ESMTPS id 3rj5e9r4u1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Jun 2023 14:06:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RkE4cTmcFJSOgmTAyUyFTJBZanglJ4HpYsyR9e1qNZ2EkN9nscph00Ia4JAbxCiGz2693hsONIFFR3yuB4iHovkYXSnRyNyd4HM4FdfoTR2P9/S6PQ4jtHnEzYqT/p4jihEErt4p5e1bDq2PeXUkPG/PyrTfia+LgL3SwEdFsYw2WHDFW/eDqFxA0cYloPSZEv/H4nXtUvcs6nmtTDOd09Fr0phjRSrHJw6n+hfqnl1ZtsHAuuTzg0Tib/FntoD8UXw1NeUmbFr13qYrXadFWdkKn+y9zbZMv+wRqZuhMhRC/InemYsGHn5jQ4UiLMjfV1wrUY+e6UZ4t5jgxOjJHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DVx8LZnEAFrVBJKppWt5JNMkoo0H9jeTToaygWHo/ds=; b=bku+Y2JSzIBtq3dT2vTZSbJMt8VeZi804MbrUC88WXWY+gXvdDjO/H6iMMSRunwTYrHdf+QVIcfgOBGmHgPa4qmmo/ReeS/iYl61CTKrjludRsQA98rYtg056Wh+jH9jzi5cpqXNQ5qunr7OiT+099sA9uTQvznQgrCUQIWW2SqrD9yydTi+irOaXY74HELvxrykNqHnGSI+Zf72iKtIXofTYC5bWcqMgukMtAQXhMlYLSLKLM4/JQwxrfXwm1doNHT+RNb5riN/Vzy5IcdVbOTLyvlcEFF5TCPZbKK0btzb5U+jnBDvAMkBwZhflf8YVN1RFVBNhdIgzwugyu6JgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 66.129.239.14) smtp.rcpttodomain=freebsd.org smtp.mailfrom=juniper.net; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=juniper.net; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DVx8LZnEAFrVBJKppWt5JNMkoo0H9jeTToaygWHo/ds=; b=ZQMZjRC9nvUmj92y4LRHm3+SnIm8/yiuNtw/fFSfiX1jDOXSDfEKkpmMx3glLIo+AhSpZaDV8JHyX8Ueg5G1ULgZpgji3oesO1+TzeA1T6yVbUmKGElXrewPa0HzKbQZx0+MF4aa+nK+8cykk+DCfCY52CaZjmRZOmIYrv/tVtM= Received: from BY3PR05CA0037.namprd05.prod.outlook.com (2603:10b6:a03:39b::12) by BL3PR05MB9137.namprd05.prod.outlook.com (2603:10b6:208:3b8::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.23; Fri, 30 Jun 2023 21:06:22 +0000 Received: from DM6NAM12FT088.eop-nam12.prod.protection.outlook.com (2603:10b6:a03:39b:cafe::8e) by BY3PR05CA0037.outlook.office365.com (2603:10b6:a03:39b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.10 via Frontend Transport; Fri, 30 Jun 2023 21:06:21 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 66.129.239.14) smtp.mailfrom=juniper.net; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=juniper.net; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.14 as permitted sender) Received: from p-exchfe-eqx-01.jnpr.net (66.129.239.14) by DM6NAM12FT088.mail.protection.outlook.com (10.13.179.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.10 via Frontend Transport; Fri, 30 Jun 2023 21:06:20 +0000 Received: from p-exchbe-eqx-01.jnpr.net (10.104.9.14) by p-exchfe-eqx-01.jnpr.net (10.104.9.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.21; Fri, 30 Jun 2023 16:06:20 -0500 Received: from p-exchbe-eqx-01.jnpr.net (10.104.9.14) by p-exchbe-eqx-01.jnpr.net (10.104.9.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.21; Fri, 30 Jun 2023 16:06:20 -0500 Received: from p-mailhub01.juniper.net (10.104.20.6) by p-exchbe-eqx-01.jnpr.net (10.104.9.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.21 via Frontend Transport; Fri, 30 Jun 2023 16:06:20 -0500 Received: from kaos.jnpr.net (kaos.jnpr.net [172.23.255.201]) by p-mailhub01.juniper.net (8.14.4/8.11.3) with ESMTP id 35UL6JPA019285; Fri, 30 Jun 2023 14:06:19 -0700 (envelope-from sjg@juniper.net) Received: by kaos.jnpr.net (Postfix, from userid 1377) id F2DB48D72C; Fri, 30 Jun 2023 14:05:52 -0700 (PDT) Received: from kaos.jnpr.net (localhost [127.0.0.1]) by kaos.jnpr.net (Postfix) with ESMTP id F255C8D55D; Fri, 30 Jun 2023 14:05:52 -0700 (PDT) To: Jessica Clarke CC: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , Subject: Re: git: 56f3f2d2491e - main - libsecureboot: avoid set but not used errors In-Reply-To: <667C347E-B7C7-405B-AFEC-F0A0FD0656F6@freebsd.org> References: <202306300652.35U6qpgP027126@gitrepo.freebsd.org> <667C347E-B7C7-405B-AFEC-F0A0FD0656F6@freebsd.org> Comments: In-reply-to: Jessica Clarke message dated "Fri, 30 Jun 2023 15:42:34 +0100." From: "Simon J. Gerraty" X-Mailer: MH-E 8.6+git; nmh 1.7.1; GNU Emacs 28.2 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <28071.1688159152.1@kaos.jnpr.net> Date: Fri, 30 Jun 2023 14:05:52 -0700 Message-ID: <28393.1688159152@kaos.jnpr.net> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM12FT088:EE_|BL3PR05MB9137:EE_ X-MS-Office365-Filtering-Correlation-Id: d0024080-fd93-4858-8768-08db79addac9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zKUkRU7z50/hgWU3zVt0OvOno5eVZJBgN+T8VxD9eypRg3j+m22HDvdyoQcCiiFLaRj9gQMONixKLMdyawMOCAFhZ2Ip2DwwrNiqcMXkENANP8qt40Xmb+nlFS4drUVSCcGViPLjnfGYSBBm+gv1uYHbfAs2T7aMYhgtvZAjdWh5MTvMDEH2/efz+lB752WoTNCYZGB3vhCXgpWdBxDbDRqU0EtgxQHhQ2X7euclRMopfC1L3JkXseyeWEuyZbvZI48XnPJ9N2ONUO7KHHhOkITruxlg5tBG2xVItm+XFjYrdMF1IkvZkl5i6l5iYLND1X/BLgpFUBBAcHMh9vOnmUMQr0PLXIwHTZ8PYFM/isUdxJdRZLkvThB3T6BJOffT/BuVZ2bnpoR598eRrhKcEgy/qgbXT9Q5SA/GR19pJaK6qcP7tKhRa8CF/QFo6c3IW8jtNZLxoCRSEDftAUhLQQd6ntGeS2CW+x6czS3qiw4p0DmpPP9DpCyRF7BtrtSj2u5NmTQYUNbCwobgX5KVNOL8itk+D1Tf3mM8RV8+BPnjl6wg8iDMZ1IAjD8Mhus5zqXYQOQC3fkAwjxfLGWuxMq6fcURzuGwvxvNweW5izCVU1M8z5xNs5wHqDTYwekbtqQxpKZtCoIeraUlf6pxnK9VK6ljW9wuL1I21zV+gBttCtvVBpiUoW052xyvYB/HtFu0a7OoALTHywGoW0D4ffF7dtfTLd+HnbcvVmqMYTfCI7YqBcVP79RICY+N4F4sq/K3czgrWM7762vglrric2oAQaD9n+Ej6ni+6f8TGDd7f0W0RRGXb3NX/BKMvEn7 X-Forefront-Antispam-Report: CIP:66.129.239.14;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:p-exchfe-eqx-01.jnpr.net;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(136003)(39860400002)(376002)(451199021)(46966006)(40470700004)(36840700001)(9686003)(26005)(82310400005)(4326008)(8936002)(36860700001)(107886003)(478600001)(54906003)(7126003)(7696005)(336012)(186003)(356005)(6266002)(4744005)(2906002)(82740400003)(40460700003)(70206006)(47076005)(41300700001)(40480700001)(316002)(55016003)(450100002)(81166007)(70586007)(5660300002)(6916009)(86362001)(8676002)(36900700001);DIR:OUT;SFP:1102; X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2023 21:06:20.8907 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d0024080-fd93-4858-8768-08db79addac9 X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4;Ip=[66.129.239.14];Helo=[p-exchfe-eqx-01.jnpr.net] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM12FT088.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR05MB9137 X-Proofpoint-GUID: OBUG_FDxVJnwvpXE4B5_ZMO65tizKRQE X-Proofpoint-ORIG-GUID: OBUG_FDxVJnwvpXE4B5_ZMO65tizKRQE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-30_12,2023-06-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=1 bulkscore=0 phishscore=0 adultscore=0 suspectscore=0 spamscore=1 clxscore=1011 priorityscore=1501 malwarescore=0 impostorscore=0 mlxscore=1 mlxlogscore=219 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306300184 X-Rspamd-Queue-Id: 4Qt7Ck0mLHz3nFF X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:22843, ipnet:67.231.152.0/24, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N Jessica Clarke wrote: > > - if (!cn.status) > > + if (!cn.status) { > > buf = NULL; > > + if (err == 0) /* keep compiler happy */ > > + buf = NULL; > > This is nonsense code. The error is nonsense, so yes. I want to keep the variable, but it has no purpose except to look at in a debugger - how do you tell the compiler that?