Date: Fri, 30 Jun 2023 14:05:52 -0700 From: "Simon J. Gerraty" <sjg@juniper.net> To: Jessica Clarke <jrtc27@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org>, <sjg@juniper.net> Subject: Re: git: 56f3f2d2491e - main - libsecureboot: avoid set but not used errors Message-ID: <28393.1688159152@kaos.jnpr.net> In-Reply-To: <667C347E-B7C7-405B-AFEC-F0A0FD0656F6@freebsd.org> References: <202306300652.35U6qpgP027126@gitrepo.freebsd.org> <667C347E-B7C7-405B-AFEC-F0A0FD0656F6@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Jessica Clarke <jrtc27@freebsd.org> wrote:
> > - if (!cn.status)
> > + if (!cn.status) {
> > buf = NULL;
> > + if (err == 0) /* keep compiler happy */
> > + buf = NULL;
>
> This is nonsense code.
The error is nonsense, so yes.
I want to keep the variable, but it has no purpose except to
look at in a debugger - how do you tell the compiler that?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?28393.1688159152>