From nobody Sat Jul 19 15:57:57 2025 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bkrsd462wz620Sl for ; Sat, 19 Jul 2025 15:57:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bkrsd2Hb0z3hmX for ; Sat, 19 Jul 2025 15:57:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752940677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tPd/Gi95SwuZ7IXETft1tD9KO8VwBEUxb1mdKJAmvLg=; b=MusnrPNJKZjx3ZmSu19ltzudTEOrSz3pEjSJACxk1MHuicIQbQpVUY9dOuYt6IsIpIo5Uj EMo2rJVAG+p3T1P/krt6KN3+5zrcIyS6t4hhWNmfujEFESG6TUupHGxqOvcfOiKRG05gqF G9d+XnKOneHUHYySKiaJdviyHULjUL303LAp96vXhoKooYLs+8BPV2kAw/AzkucODR/aDb pbSZ0VRiqtZkhCsUej1wM5sEeuuwrDXX6YqpFMvP0E4zH1CgjiJPOtrU7hnirXIeJuABqd a88dQaFCkxToIaKO1ks69AwjXYx1ZemlrMUHWToj9qG6ufZQuy5DeciIGYGKNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752940677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tPd/Gi95SwuZ7IXETft1tD9KO8VwBEUxb1mdKJAmvLg=; b=ubW3kYhiZPfEg1bvhnM38aHkFwLRfq6GfWYzOfxCvdSqJpVxpC+u6mFjUMhCmXYbaHT+KK ci4708oEjemJ7zP5njfbyCWNGQkjB0BQ6UEoHYb/4zZQw0jP00I7UJfkokrZNaxSlTacWZ cPJwWy9BjEtlllSRAMuuAsTFaCi2EQUQ0oPI/AJYC7JvUduxfOdn7LKOCbOZk0ljX9uEgh uwEe7GyaTvNEOTzPHOjaTBD0dP/cDZV/0kUEcHEHpAkl+2n/jDOsi3ZsESstMVflLq0buW R6vynqAetehwVbNCO/u/lMW1g4MwavZxl9dKeTaYmotQu6+XcO88fGFX7bOTjg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1752940677; a=rsa-sha256; cv=none; b=fReTI4NiPbSMgd4t2MT57XG0T2jqmK8bbvXRGtovXEHdg/pfiQMqQmOSj5oSSlzpKJfWzf 93uYdXR60T6D+6ngPZjapWhoGSfjTbrAR4VCK8s7w5SHO3bIAFQharipRynTJPU0lvXcbm FzIvnL2LVewaC3VxKL/8iQxZv/+Ma8C18ozi3BiNztO8r5KjgEeLZGvCf30ugcp4pANsTE A3tnpwgW4skipAcPnQ0MYjEsz1Xy8sepK6DRSuV5ZwPZuJdhpIJwCWRswyYf35m5RkDYFa z2NlYWR4H/P+1V5d6+E3kQ1wPHyn0f1+n5N3r08U0TnENuP8aqDWZ83Ir8bIYw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bkrsd1tzczZN0 for ; Sat, 19 Jul 2025 15:57:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 56JFvv8x046920 for ; Sat, 19 Jul 2025 15:57:57 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 56JFvveX046919 for net@FreeBSD.org; Sat, 19 Jul 2025 15:57:57 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 288309] genet driver memory leak in dma teardown (cut and paste issue) Date: Sat, 19 Jul 2025 15:57:57 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.5-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: zlei@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D288309 --- Comment #1 from Zhenlei Huang --- (In reply to Mike Belanger from comment #0) > There is a memory leak in an error path where gen_bus_dma_teardown is cal= led > The tx_buf_tag is checked in both cases instead of checking the rx_buf_ta= g in > the second case where rx dma mappings are destroyed. That is obviously true. > However we have added a detach handler that is leveraging this function. > Please consider adding a detach handler. Can you elaborate the usage for adding the detach handler ? --=20 You are receiving this mail because: You are the assignee for the bug.=