From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Feb 14 20:10:01 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 25798106566B for ; Sat, 14 Feb 2009 20:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 0095A8FC18 for ; Sat, 14 Feb 2009 20:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n1EKA0Hg011325 for ; Sat, 14 Feb 2009 20:10:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n1EKA0u6011324; Sat, 14 Feb 2009 20:10:00 GMT (envelope-from gnats) Resent-Date: Sat, 14 Feb 2009 20:10:00 GMT Resent-Message-Id: <200902142010.n1EKA0u6011324@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Josh Carroll Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 680C3106564A for ; Sat, 14 Feb 2009 20:00:59 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 4ABC78FC14 for ; Sat, 14 Feb 2009 20:00:59 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n1EK0xCu041484 for ; Sat, 14 Feb 2009 20:00:59 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n1EK0xmm041483; Sat, 14 Feb 2009 20:00:59 GMT (envelope-from nobody) Message-Id: <200902142000.n1EK0xmm041483@www.freebsd.org> Date: Sat, 14 Feb 2009 20:00:59 GMT From: Josh Carroll To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/131681: Add OPTIONS framework to gpac-libgpac port X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Feb 2009 20:10:01 -0000 >Number: 131681 >Category: ports >Synopsis: Add OPTIONS framework to gpac-libgpac port >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Feb 14 20:10:00 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Josh Carroll >Release: 7.1-RELEASE/amd64 >Organization: n/a >Environment: FreeBSD pflog.net 7.1-RELEASE FreeBSD 7.1-RELEASE #0: Sat Jan 3 09:49:18 EST 2009 root@pflog.net:/usr/obj/usr/src/sys/PFLOG amd64 >Description: I wanted to disable IPv6 and OpenGL support for the gpac-libgpac port, but there were no existing knobs. So I added OPTIONS support to this port and added two configurable options to enable/disable IPV6 and OpenGL. Both default to "on" and thus the port should build by default with the same options as before. I also made a minor change to the CONFIGURE_ARGS to add --enable-pic rather than manually adding -fPIC to the --extra-ldflags option. Below is the plain text of the patch (in case the attachment does not work - I seem to have problems attaching patches to PRs - user error, I know). Thanks! Josh >How-To-Repeat: n/a >Fix: diff -urN gpac-libgpac.old/Makefile gpac-libgpac/Makefile --- gpac-libgpac.old/Makefile 2009-02-14 13:52:47.000000000 -0500 +++ gpac-libgpac/Makefile 2009-02-14 14:54:56.000000000 -0500 @@ -27,9 +27,22 @@ LIBVER= 1 CONFIGURE_ARGS= --cc="${CC}" \ - --extra-cflags="${CFLAGS} ${PTHREAD_CFLAGS} -fPIC" \ - --extra-ldflags="${LDFLAGS} ${PTHREAD_LIBS}" \ - --disable-opengl + --enable-pic \ + --extra-cflags="${CFLAGS} ${PTHREAD_CFLAGS}" \ + --extra-ldflags="${LDFLAGS} ${PTHREAD_LIBS}" + +OPTIONS= OPENGL "OpenGL support" on \ + IPV6 "IPv6 support" on + +.include + +.if defined(WITHOUT_OPENGL) +CONFIGURE_ARGS+= --disable-opengl +.endif + +.if defined(WITHOUT_IPV6) +CONFIGURE_ARGS+= --disable-ipv6 +.endif post-patch: ${CHMOD} +x ${WRKSRC}/configure @@ -42,4 +55,4 @@ ${LN} -sf libgpac.so.${LIBVER} ${PREFIX}/lib/libgpac.so ${INSTALL_DATA} ${INSTALL_WRKSRC}/libgpac_static.a ${PREFIX}/lib -.include +.include Patch attached with submission follows: diff -urN gpac-libgpac.old/Makefile gpac-libgpac/Makefile --- gpac-libgpac.old/Makefile 2009-02-14 13:52:47.000000000 -0500 +++ gpac-libgpac/Makefile 2009-02-14 14:54:56.000000000 -0500 @@ -27,9 +27,22 @@ LIBVER= 1 CONFIGURE_ARGS= --cc="${CC}" \ - --extra-cflags="${CFLAGS} ${PTHREAD_CFLAGS} -fPIC" \ - --extra-ldflags="${LDFLAGS} ${PTHREAD_LIBS}" \ - --disable-opengl + --enable-pic \ + --extra-cflags="${CFLAGS} ${PTHREAD_CFLAGS}" \ + --extra-ldflags="${LDFLAGS} ${PTHREAD_LIBS}" + +OPTIONS= OPENGL "OpenGL support" on \ + IPV6 "IPv6 support" on + +.include + +.if defined(WITHOUT_OPENGL) +CONFIGURE_ARGS+= --disable-opengl +.endif + +.if defined(WITHOUT_IPV6) +CONFIGURE_ARGS+= --disable-ipv6 +.endif post-patch: ${CHMOD} +x ${WRKSRC}/configure @@ -42,4 +55,4 @@ ${LN} -sf libgpac.so.${LIBVER} ${PREFIX}/lib/libgpac.so ${INSTALL_DATA} ${INSTALL_WRKSRC}/libgpac_static.a ${PREFIX}/lib -.include +.include >Release-Note: >Audit-Trail: >Unformatted: