From nobody Sat Sep 13 18:55:52 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cPL9c2vQCz67N1R for ; Sat, 13 Sep 2025 18:56:20 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cPL9b4fynz3JNg for ; Sat, 13 Sep 2025 18:56:19 +0000 (UTC) (envelope-from 6yearold@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of 6yearold@gmail.com designates 209.85.128.180 as permitted sender) smtp.mailfrom=6yearold@gmail.com Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-72ce9790aceso20493657b3.3 for ; Sat, 13 Sep 2025 11:56:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757789778; x=1758394578; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=HycdVK0hexVs8308iKxuFs7fyNHv+G7kcZy8/0ac+VY=; b=KyyMQ5lvTgURHJ0E9FE2qWOjB3MCkpjGVJu+XTDdxIJEGsKYSJaTbCOc46l0VVLawI 7fm+OdKpzlEz7ztOggG4E2lzODxjI1tosepIwSx1v5irkQassMdyak1de1msPQiyVnaj 7K9WUSXOoPtn9nxN2HofevttMwgWC3ZyZqk3RnkA9jI5F9AElwD/OjYtrbBsM4UdaGzh W/TizbSITMFQl34OeFLibXdRTt9ezjo1MU1r1T5TJb1ffixmJNMBdUSOK3DQffiZh8zy /krGBT1gNvsl3kZL+dobnw2IV7fRz6nhSiPjbEfRjU697iftvRbruB1J17J3bQj8RBCb Mj0g== X-Forwarded-Encrypted: i=1; AJvYcCUelKhGZNEuijxs6GIVp5gAmWCnVmmcbkFqD9uEfYGPJN1QBy0m6Ea166PYtLq7aFkNIXDPRNlUEiS8CiqeniQUePry@freebsd.org X-Gm-Message-State: AOJu0YyeoZFkxfzxYbyokyFEHmmD5oF1p4BmkyMPiSsBuPXgtE57NIQR LFyVfnDce5mF5wpa1oekCcYXP/KD1DfCgodnOFDgAvMYEf7Nz85iRyIu366JsaidA/I= X-Gm-Gg: ASbGncuWCxbgwPdfV6iIOzMtMihtyz1gdplNDW7kud1vcQA9VQLXo/kjB1vjnULb2UN K/FuIY/C/Sw8g/4j92s9aThMZGuYyG7uy9eSfrDJUa8NnWZiIqnqdtOjBFgLHUFQYAWBhiJTJWk DZn/5Jb7HHri6H+6mNGcXuLGxtULs5L+Tv45KaTdKbex49o0Hl9pZL2afNay2DJ1QcdQkGHwGRf OQNZoszicomkZJCz7U6OVQcFJ5Qx7hsv4mM+JWFJUtkhHffC/P1x1C1yQcbFdKFhr3igz9WoOVq QbxxRIK4fvKtb/TlsBPHnsD5B0pBxfecvOfGOgY4s+LphBhmVwASZc6ZqZATKkkwbbjY1AlcOks U2qLgU91Ti+Rk9BpTtYnIJuCvtUJkKeyHCKbNIA3EWZURwA+bzxN849M2DeqWyQ== X-Google-Smtp-Source: AGHT+IHByhMTFKy7OqxeR4kgSvPN+7NEtGbTLBx42crQk6rsOTFJAU/P450naFt262QMq5xf+AdyOQ== X-Received: by 2002:a05:690c:6f04:b0:723:be82:c78a with SMTP id 00721157ae682-7306443692cmr59890097b3.31.1757789778590; Sat, 13 Sep 2025 11:56:18 -0700 (PDT) Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com. [209.85.128.170]) by smtp.gmail.com with ESMTPSA id 00721157ae682-73241b01ceesm5521297b3.20.2025.09.13.11.56.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Sep 2025 11:56:18 -0700 (PDT) Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-71d60110772so23381667b3.0 for ; Sat, 13 Sep 2025 11:56:18 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVuSHOeaFN+L2XhlI5LJQRRglfU2+yZdGwp4bAuBoGjUrc6+6Vx9iUa4t0KN4oYrfs9zP0xqdMioL32n7Fh8JiipEK+@freebsd.org X-Received: by 2002:a05:690c:4d49:b0:71c:1673:7bcb with SMTP id 00721157ae682-73064434cfemr73502307b3.27.1757789778273; Sat, 13 Sep 2025 11:56:18 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 From: Gleb Popov Date: Sat, 13 Sep 2025 21:55:52 +0300 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXzsqHa-WuJ_oiWswYHh8p-cPKICWSGtBM7PfdP1SfqQoZ_afFBW3evVU2w Message-ID: Subject: Re: git: fd9e09cb2ab0 - main - kern: replace several EBADF with EINVAL To: kib@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Spamd-Bar: / X-Spamd-Result: default: False [0.11 / 15.00]; FAKE_REPLY(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_SPAM_MEDIUM(0.99)[0.992]; NEURAL_HAM_SHORT(-0.98)[-0.981]; FORGED_SENDER(0.30)[arrowd@freebsd.org,6yearold@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_THREE(0.00)[3]; ARC_NA(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; RCVD_IN_DNSWL_NONE(0.00)[209.85.128.180:from,209.85.128.170:received]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_NONE(0.00)[]; FROM_NEQ_ENVFROM(0.00)[arrowd@freebsd.org,6yearold@gmail.com]; MISSING_XM_UA(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.128.180:from]; FROM_HAS_DN(0.00)[] X-Rspamd-Queue-Id: 4cPL9b4fynz3JNg This change affects following code inside the Qt library: https://github.com/qt/qtbase/blob/d6cc7562689d8a07bc933178ea367706ca38e4ac/src/3rdparty/forkfd/forkfd.c#L902 The code in question expects to receive EBADF when being fed a wrong type of the descriptor. Returning EINVAL makes sense to me, so maybe we should patch Qt rather than revert this change?