From owner-freebsd-current Wed Jun 6 20: 1:51 2001 Delivered-To: freebsd-current@freebsd.org Received: from peter3.wemm.org (c1315225-a.plstn1.sfba.home.com [65.0.135.147]) by hub.freebsd.org (Postfix) with ESMTP id E456F37B407 for ; Wed, 6 Jun 2001 20:01:46 -0700 (PDT) (envelope-from peter@wemm.org) Received: from overcee.netplex.com.au (overcee.wemm.org [10.0.0.3]) by peter3.wemm.org (8.11.0/8.11.0) with ESMTP id f5731kM52356 for ; Wed, 6 Jun 2001 20:01:46 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by overcee.netplex.com.au (Postfix) with ESMTP id B4B09380A; Wed, 6 Jun 2001 20:01:46 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.3.1 01/18/2001 with nmh-1.0.4 To: Richard Todd Cc: current@freebsd.org Subject: Re: recent change to ata-disk.c seems to be horked... In-Reply-To: Date: Wed, 06 Jun 2001 20:01:46 -0700 From: Peter Wemm Message-Id: <20010607030146.B4B09380A@overcee.netplex.com.au> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Bah, what a brilliant end to an already bad day. :-( I managed to commit a patch that I changed last night, and when recompiling today before commit, I used the wrong tree. I was in a rush to get home for my son's grade 1 class school musical. Yes, it cannot possibly work. :-( Fixing it now.. Argh! Richard Todd wrote: > Just tried to build a kernel with freshly-supped sources and got: > > cc -c -O -pipe -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extens ions -ansi -g -nostdinc -I- -I. -I../.. -I../../dev -I../../../include -I. ./../contrib/dev/acpica -D_KERNEL -include opt_global.h -elf -mpreferred- stack-boundary=2 ../../dev/ata/ata-disk.c > ../../dev/ata/ata-disk.c:88: syntax error before `&' > ../../dev/ata/ata-disk.c:55: warning: `adopen' used but never defined > ../../dev/ata/ata-disk.c:56: warning: `adstrategy' used but never defined > ../../dev/ata/ata-disk.c:57: warning: `addump' used but never defined > ../../dev/ata/ata-disk.c:58: warning: `ad_cdevsw' defined but not used > ../../dev/ata/ata-disk.c:73: warning: `addisk_cdevsw' defined but not used > ../../dev/ata/ata-disk.c:76: warning: `ad_invalidatequeue' declared `static' but never defined > ../../dev/ata/ata-disk.c:77: warning: `ad_tagsupported' declared `static' but never defined > ../../dev/ata/ata-disk.c:78: warning: `ad_timeout' declared `static' but neve r defined > ../../dev/ata/ata-disk.c:79: warning: `ad_free' declared `static' but never d efined > ../../dev/ata/ata-disk.c:80: warning: `ad_version' declared `static' but neve r defined > ../../dev/ata/ata-disk.c:83: warning: `adp_lun_map' defined but not used > ../../dev/ata/ata-disk.c:85: warning: `ata_dma' defined but not used > ../../dev/ata/ata-disk.c:86: warning: `ata_wc' defined but not used > ../../dev/ata/ata-disk.c:87: warning: `ata_tags' defined but not used > *** Error code 1 > > Stop in /usr/src/sys/compile/ICHOTOLOTSMP. > > Line 88 is in the diffs that peter just recently committed (rev 1.106; see > the commitlogs/sys entry for 2001/06/06 15:17:09 PDT). The offending line > is > TUNABLE_INT("hw.ata.ata_dma", &ata_dma); > > Looking at the definition of TUNABLE_INT, it doesn't look like it'd take well > to having the 2nd argument (var) be something beginning with &, given that th e > first thing the definition does is try to define a function based on the var > given, in this case > static void __Tunable_&ata_dma (void *ignored) > > See the problem? > > > > Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message