From owner-cvs-all@FreeBSD.ORG  Sun Apr  3 14:10:43 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6F1BB16A4CE; Sun,  3 Apr 2005 14:10:43 +0000 (GMT)
Received: from mail.chesapeake.net (chesapeake.net [208.142.252.6])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id F26F743D2D; Sun,  3 Apr 2005 14:10:42 +0000 (GMT)
	(envelope-from jroberson@chesapeake.net)
Received: from mail.chesapeake.net (localhost [127.0.0.1])
	by mail.chesapeake.net (8.12.10/8.12.10) with ESMTP id j33EAg9P040237;
	Sun, 3 Apr 2005 10:10:42 -0400 (EDT)
	(envelope-from jroberson@chesapeake.net)
Received: from localhost (jroberson@localhost)j33EAfDi040230;
	Sun, 3 Apr 2005 10:10:41 -0400 (EDT)
	(envelope-from jroberson@chesapeake.net)
X-Authentication-Warning: mail.chesapeake.net: jroberson owned process doing
	-bs
Date: Sun, 3 Apr 2005 10:10:41 -0400 (EDT)
From: Jeff Roberson <jroberson@chesapeake.net>
To: Scott Long <scottl@FreeBSD.org>
In-Reply-To: <20050403074335.A35686@pooker.samsco.org>
Message-ID: <20050403101013.U54623@mail.chesapeake.net>
References: <200504031029.j33ATtAX021544@repoman.freebsd.org>
 <20050403074335.A35686@pooker.samsco.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: Jeff Roberson <jeff@FreeBSD.org>
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/ufs/ffs ffs_extern.h ffs_softdep.c        
 ffs_vfsops.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Apr 2005 14:10:43 -0000


On Sun, 3 Apr 2005, Scott Long wrote:

> On Sun, 3 Apr 2005, Jeff Roberson wrote:
> > jeff        2005-04-03 10:29:55 UTC
> >
> >  FreeBSD src repository
> >
> >  Modified files:
> >    sys/ufs/ffs          ffs_extern.h ffs_softdep.c ffs_vfsops.c
> >  Log:
> >   - Move the contents of softdep_disk_prewrite into ffs_geom_strategy to fix
> >     two bugs.
> >   - ffs_disk_prewrite was pulling the vp from the buf and checking for
> >     COPYONWRITE, when really it wanted the vp from the bufobj that we're
> >     writing to, which is the devvp.  This lead to us skipping the copy on
> >     write to all file data, which significantly broke snapshots for the
> >     last few months.
> >   - When the SOFTUPDATES option was not included in the kernel config we
> >     would also skip the copy on write check, which would effectively disable
> >     snapshots.
>
> I thought that snapshots required softupdates?

Kirk told me they weren't today, and I tested them without softupdates
enabled.  It seemed to work just fine.

>
> Scott
>