From owner-freebsd-bugs@FreeBSD.ORG Sun Oct 16 15:30:26 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 818011065672 for ; Sun, 16 Oct 2011 15:30:26 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 457158FC13 for ; Sun, 16 Oct 2011 15:30:26 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p9GFUQ9l057961 for ; Sun, 16 Oct 2011 15:30:26 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p9GFUQjO057951; Sun, 16 Oct 2011 15:30:26 GMT (envelope-from gnats) Resent-Date: Sun, 16 Oct 2011 15:30:26 GMT Resent-Message-Id: <201110161530.p9GFUQjO057951@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Manolis Kiagias Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1B8D2106566B for ; Sun, 16 Oct 2011 15:26:22 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 0B6A88FC12 for ; Sun, 16 Oct 2011 15:26:22 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p9GFQLFH002277 for ; Sun, 16 Oct 2011 15:26:21 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p9GFQLPj002276; Sun, 16 Oct 2011 15:26:21 GMT (envelope-from nobody) Message-Id: <201110161526.p9GFQLPj002276@red.freebsd.org> Date: Sun, 16 Oct 2011 15:26:21 GMT From: Manolis Kiagias To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/161711: [patch] bsdinstall(8) does not quote the keymap setting in rc.conf X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2011 15:30:26 -0000 >Number: 161711 >Category: bin >Synopsis: [patch] bsdinstall(8) does not quote the keymap setting in rc.conf >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Oct 16 15:30:25 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Manolis Kiagias >Release: 9.0-BETA3 >Organization: >Environment: >Description: When selecting a keyboard map during installation with bsdinstall, the relevant rc.conf entry is written without quotes. While quotes are not necessary, all entries have had them till now (sysinstall always quoted settings) and it also seems every other bsdinstall entry is quoted. Apparently the problem lies with the kbdmap program called from bsdinstall. >How-To-Repeat: Select a keyboard map during installation. Look at the rc.conf entry after installation. >Fix: Apply the following patch to kbdmap.c Patch attached with submission follows: --- kbdmap.c.original 2011-10-16 18:12:55.000000000 +0300 +++ kbdmap.c 2011-10-16 18:14:12.000000000 +0300 @@ -289,7 +289,7 @@ if (!x11) system(kbd_cmd); - fprintf(stderr, "keymap=%s\n", km->keym); + fprintf(stderr, "keymap=\"%s\"\n", km->keym); free(kbd_cmd); } >Release-Note: >Audit-Trail: >Unformatted: