From owner-svn-ports-all@FreeBSD.ORG Thu May 30 18:50:40 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 833C2C77 for ; Thu, 30 May 2013 18:50:40 +0000 (UTC) (envelope-from ohauer@gmx.de) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by mx1.freebsd.org (Postfix) with ESMTP id 16D4ED6D for ; Thu, 30 May 2013 18:50:39 +0000 (UTC) Received: from mailout-de.gmx.net ([10.1.76.20]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0LqXa3-1UCtmI0YjZ-00e7ZK for ; Thu, 30 May 2013 20:50:39 +0200 Received: (qmail invoked by alias); 30 May 2013 18:50:38 -0000 Received: from p578be941.dip0.t-ipconnect.de (EHLO [192.168.0.100]) [87.139.233.65] by mail.gmx.net (mp020) with SMTP; 30 May 2013 20:50:38 +0200 X-Authenticated: #1956535 X-Provags-ID: V01U2FsdGVkX18uKLUG9XMuXOVEV3fJoy5WSzEx7A8/YadYijC633 3lPbQPXBdeZzVB Message-ID: <51A79F82.9030400@gmx.de> Date: Thu, 30 May 2013 20:50:42 +0200 From: olli hauer User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Eitan Adler Subject: Re: svn commit: r319380 - head/math/libtommath References: <201305291541.r4TFf1PO037359@svn.freebsd.org> In-Reply-To: X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 Cc: bf1783@gmail.com, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Martin Wilke X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 May 2013 18:50:40 -0000 On 2013-05-30 20:24, Eitan Adler wrote: > On 30 May 2013 19:47, b.f. wrote: >> On 5/30/13, Eitan Adler wrote: >>> On 30 May 2013 03:42, Martin Wilke wrote: >>>> >>>> On May 30, 2013, at 5:17 AM, Eitan Adler wrote: >>>> >>>>> On 29 May 2013 17:41, Martin Wilke wrote: >>>>>> Author: miwi >>>>>> Date: Wed May 29 15:41:00 2013 >>>>>> New Revision: 319380 >>>>>> URL: http://svnweb.freebsd.org/changeset/ports/319380 >>>>>> >>>>>> Log: >>>>>> - Disable regression test >>>>>> >>>>>> Reported by: pointyhat building 2(D)-02:56:27 >>>>> >>>>> This doesn't really explain what happened here. >>>>> Did the regression test fail? Did the tests fail to build? Are there >>>>> no regression tests? >>>>> >>>>> If the tests failed are they false positives, or do they indicate >>>>> actual problems (where the port should be marked BROKEN)? >>>>> >>>> >>>> the regression test hangs without timeout thats why i have disable it. >>>> port it self builds fine no reason to mark it broken. >>> >>> Do the hangs indicate failure of the test program or failure of the >>> actual program? >>> If the latter it should be marked BROKEN. >> >> We don't automatically mark ports as BROKEN if they fail to pass a >> test -- if we did, a great many more ports would be unavailable, >> because most ports don't perform perfectly. Often test failures are >> caused by the conditions in which the tests are run, or are due to >> problems in the testsuite, or represent uncommon or minor problems >> that should ultimately be fixed, but don't render the port useless in >> the meantime. > > Please read what I asked carefully. > > Is the failure an indication of a broken program? > > BROKEN is not used just because a port fails its regression tests but > it isn't reserved just for build failures. > Even as non native English speaker I read it as the regression-test runs for a very long time and is not practicable to run on pointyhat or any build system. > Reported by: pointyhat building 2(D)-02:56:27 If you take a look into libtommath-0.42.0/mtest/mtest.c you will find a for(;;) loop to generate test data which explains the long time running. So the commit message is fine.