From owner-freebsd-scsi@FreeBSD.ORG Tue Sep 18 20:23:00 2007 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2DF2F16A46B for ; Tue, 18 Sep 2007 20:23:00 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.186]) by mx1.freebsd.org (Postfix) with ESMTP id 00EE113C4B5 for ; Tue, 18 Sep 2007 20:22:58 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: by nf-out-0910.google.com with SMTP id b2so1520779nfb for ; Tue, 18 Sep 2007 13:22:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:received:received:date:from:to:cc:subject:message-id:mail-followup-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; bh=IoiYFbMKieWHWmAvwq530lFhpUJjcxGGloLsp0qA4eY=; b=EYAFRagqPf9cpVWY/4ddpJl6M8SrB5TFMY1BcJHPijYiDDDupLNeWnlcVlOtVHDww+iSdieL6MSARR2lYWYRmrGmXzAgsZ0viMXXwJyg2Aa9bMB9fHywhqxVVUEIvHdtFpTBuvE+CH8O/c/C3Jn1AO9XI+1mFFVjde7AM1+ti44= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:from:to:cc:subject:message-id:mail-followup-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=BbUIELtpnrghbQ6nKtqWpxB1f2CnL83oY/LOJM7lveWbEYjFOlFS7r6yZiLho07YmJKN/K4kKaE8E2/Q06mCHV3//3LMRsW2Qvn6xQBOl0w/GAoqrI0TdbFFquFNy7GjuxHe4KwRpiGTVWMOqFg7oQBt2bM87eX62T2gPmLtd1g= Received: by 10.86.80.5 with SMTP id d5mr4934642fgb.1190146977585; Tue, 18 Sep 2007 13:22:57 -0700 (PDT) Received: from roadrunner.spoerlein.net ( [85.180.172.144]) by mx.google.com with ESMTPS id b17sm11033940fka.2007.09.18.13.22.56 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 18 Sep 2007 13:22:57 -0700 (PDT) Received: from roadrunner.spoerlein.net (localhost [127.0.0.1]) by roadrunner.spoerlein.net (8.14.1/8.14.1) with ESMTP id l8IKMpKB001445; Tue, 18 Sep 2007 22:22:51 +0200 (CEST) (envelope-from uspoerlein@gmail.com) Received: (from q@localhost) by roadrunner.spoerlein.net (8.14.1/8.14.1/Submit) id l8IKMopD001444; Tue, 18 Sep 2007 22:22:50 +0200 (CEST) (envelope-from uspoerlein@gmail.com) Date: Tue, 18 Sep 2007 22:22:50 +0200 From: Ulrich Spoerlein To: Scott Long Message-ID: <20070918202250.GA1403@roadrunner.spoerlein.net> Mail-Followup-To: Scott Long , freebsd-scsi@FreeBSD.ORG, freebsd-current@FreeBSD.ORG, njl@FreeBSD.ORG References: <46E615C4.1010605@samsco.org> <20070916115427.GA1427@roadrunner.spoerlein.net> <46ED6C50.4040104@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46ED6C50.4040104@samsco.org> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: freebsd-scsi@FreeBSD.ORG, njl@FreeBSD.ORG, freebsd-current@FreeBSD.ORG Subject: Re: Retirement of CAM_QUIRK_NOSERIAL X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Sep 2007 20:23:00 -0000 On Sun, 16.09.2007 at 11:48:00 -0600, Scott Long wrote: > Ulrich Spoerlein wrote: > > On Mon, 10.09.2007 at 22:12:52 -0600, Scott Long wrote: > >> All, > >> > >> The attached patch should make CAM behave properly with regard to > >> probing device serial numbers only when the device advertises that > >> it supports it. It will hopefully eliminate the need for the > >> CAM_QUIRK_NOSERIAL quirk (one instance is left because of an unrelated > >> legacy problem that may or may not be possible to fix). This should > >> especially benefit USB-UMASS devices, where the console output should > >> be less noisy. It might even make more devices work out-of-the-box. > > While this patch is working fine with my USB/FW HDD enclosure, it breaks > > my MP3 USB stick > > kernel: umass0: on uhub5 > > kernel: umass0: BBB reset failed, IOERROR > > kernel: umass0: BBB bulk-in clear stall failed, IOERROR > > kernel: umass0: BBB bulk-out clear stall failed, IOERROR > > Is this a regression of something that works without the patch, or is > it something that has never worked? What happens if you use the > NO_INQUIRY_EVPD quirk instead? Ok, I played around a bit and with your patch applied, I have to *remove* the quirk for my Samsung device, then it starts attaching again. That's a good thing, right? :) umass0: on uhub3 da0 at umass-sim0 bus 0 target 0 lun 0 da0: Removable Direct Access SCSI-4 device da0: 40.000MB/s transfers da0: 999MB (511616 2048 byte sectors: 64H 32S/T 249C) There are only two other devices right now, that require a SHUTTLE_INIT quirk, perhaps they are broken by your patch, too. Btw, why are there devices in umass.c with NO_QUIRKS set? Shouldn't those entries be removed? Cheers, Ulrich Spoerlein -- It is better to remain silent and be thought a fool, than to speak, and remove all doubt.