From owner-svn-ports-head@freebsd.org  Thu Feb 25 09:35:14 2021
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1C4A855CEC2;
 Thu, 25 Feb 2021 09:35:14 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4DmSLp0NSqz4RXl;
 Thu, 25 Feb 2021 09:35:14 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;
 t=1614245714;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=6oG89u6kBNDJbupkX/UKzwi34NSmhFNGY6bam1v1pMs=;
 b=v1Rmq9TQEgJFr6VHzctnLv2vBcZChEcDKM/2RURhXb/M6k1eOjejEhA7r6DwGEioMq1TQ5
 Nf8KbbXxfzGEjRUJhLhHyr5bSQ2p+cCZ5A+Fgd/gTFj4ujxZe0Rgxrjf1UjOgdem8prFWv
 ZAJFNvqOLFL9fm9ViuzUQJQsEJLGXJkPhutklUe+N71SWn8GoJoY+zVyzbyOWNQhVOrXLc
 eTGWHYIv5MIuCkyIZa1rWpsvTM50K4ib/Z9tUGv0jjmkPasRS81DqHUVEEMmM4byqFtHxh
 mN57hac9r2ex5nAFbZIImywHz05o/dQRKn2IIh3+g+thrvPs6Qj9wyHjBgTKbQ==
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id F1AB113FD4; Thu, 25 Feb 2021 09:35:13 +0000 (UTC)
Date: Thu, 25 Feb 2021 09:35:13 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Mathieu Arnold <mat@freebsd.org>
Cc: Adriaan de Groot <adridg@freebsd.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r566508 - in head: Mk/Uses devel/qt5-core
 devel/qt5/files
Message-ID: <20210225093513.GA59@FreeBSD.org>
References: <202102242045.11OKjEpT075754@repo.freebsd.org>
 <20210225091804.qip5ehkragajibmg@aching.in.mat.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210225091804.qip5ehkragajibmg@aching.in.mat.cc>
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;
 s=dkim; t=1614245714;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=6oG89u6kBNDJbupkX/UKzwi34NSmhFNGY6bam1v1pMs=;
 b=AFS02D3sGho2ZI3BPXUgOtNMPKDMqra3IJtwqrHgAHzrbkiOcPO4HamlzSW1iLLDIe9Ejx
 vyoaStZaVTFYNABLFRc+9HztDLzEhV0rqBLpd67n3T2luR8kRC8qka6igzasyXjKs6ndPo
 ewNdaoAAboWv8glvO1rY4060v3QSfqb6Ya56tV9BAFdP4m/NjBBWSeO+mJzFJrzI3Nk/N+
 LthGZ+npUfPCUDQFnQWCTEIzQ2LhmVyaekEoRglMsYuiZUrFPjPcQxRAIOfsHmnd660dwT
 cSKZUXLWS3f1neVGZZ0esJFlMq78NNDBBMVvXTVEfS7mR3DBjHY0z2bSmhzuGQ==
ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1614245714; a=rsa-sha256; cv=none;
 b=EoMFBc3RNXEO5i68SwKGwF+Mfh3PaihH3MC3EvrpIZjspurkTzVa48giLdelGHcYFasSpC
 qg1kG58jOvs/Hc6a0KGuw8FLYfYKhdb/lZVqsKqXjBTpflycI/v92H06vCxiqXew3qJWm3
 CvHC8Rivc3yJJ1BUmxRg/PQIuP1wCGUFm2KlRGiCG5GJZtG+Pdc4lVJ61VatxDtP/5OxHD
 lc+G/9mTVY++wt5WGO1NWcNhPPBa9v+MA47Iru77c134OKXHdiMx7OUYiJOwm6oBtr0gnb
 nTdlkzVmXnVQa3EsWfXZ28uuHFrXUenjn3BnCyWIErP5uwgPCGfqBmC5eI3TWg==
ARC-Authentication-Results: i=1;
	mx1.freebsd.org;
	none
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Feb 2021 09:35:14 -0000

On Thu, Feb 25, 2021 at 10:18:04AM +0100, Mathieu Arnold wrote:
> On Wed, Feb 24, 2021 at 08:45:14PM +0000, Adriaan de Groot wrote:
> > -	@${REINPLACE_CMD} 's/\t//g' ${PKGINSTALL} ${PKGDEINSTALL}
> > +	# Drop all leading spaces in the script, to minify
> > +	@${REINPLACE_CMD} 's/^  *//' ${PKGINSTALL} ${PKGDEINSTALL}
> 
> [[:space:]] works with all versions.

Yes please.  Not just it's more robust, it also expresses the intention
better, as we probably want to trim *any* unnecessary whitespace, not
some particular character.

./danfe