From owner-svn-src-all@freebsd.org Thu Apr 18 03:59:01 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6FFD41586A75 for ; Thu, 18 Apr 2019 03:59:01 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound2m.ore.mailhop.org (outbound2m.ore.mailhop.org [54.149.155.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DAE8E74953 for ; Thu, 18 Apr 2019 03:59:00 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1555559939; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=MmP13xKm/TcTfjxkNrmvJMXOi10cxDdFfArp0kOIt1TAvFLMQehkLylljbtTpXQEwSi9SLlJbKpTj y/VgiU/1+M4WtM0wONhtbYRZP801om19plVf2eJYr7kbjBGFQcBis/CAfEQslMDE2FweM0VWAqvJx+ R7U+cAMoa2s3cf1S3EcSUT+1uI5p7nXXjhvOYEa8mGHhC8LnBVH2IqPmsMV4dvROXFiAzazkVOp4U1 S1JobSXQY44FGw1C9OBZgGRqNbXMmuTtefyDr4jYnIhigLRNRASsTrlStMkkMxWPgCzQHhgWysFF5S w3kCOogY6uk2DWUd49Svz6w6FjNWf+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=9xBd3RRjOpajcMhiX5EWBANgA0MbD9QOp9d3myxnPU8=; b=PXTyQvL5gUiBUjBi8lt44jWgG64GnrEOXCg9nnz5cGNCZBHSojqGYP1gCj6QsaY6w+pHZA1r+n3iy J5sxX8yBPh+9A27aP9+XxjcUTRzvBhuzolxJtqeEtKVRJQ+hMyQMTcKaXvjeeVtnCbfKK03VyI5yar 4tD0LboId81w4jPfHqzU8euwYUoyqXbSwX0g2d/YQTGKit13dmYCrk5sPPms/ZvRVv2nhC8hCgy8lF uh0ZBdrbvKOIUXjFpySFvRS56gd2j2Lzhu9Yi4QQ+aH2BJxTahSAdzoHEGSwHZFPAuihPzWHIf6lb3 6wVXgV4sUKVYYb2OzFME4dbAK+xLRog== ARC-Authentication-Results: i=1; outbound4.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=9xBd3RRjOpajcMhiX5EWBANgA0MbD9QOp9d3myxnPU8=; b=o+DGenKAJ1VMoKZQEs8eHdER6LDMPhkPtUFmsDTQalkyg7GAKu3Jc9nK5IIEKy+x5blmSyHyjNRz9 kmvQHe0X5kTPeZxKpcwlRRDNLRat9ZoLOMxboNFAYZsZXoR3FMr1beeMKOGk3VFrAxkcegiAH5Lr91 yiYw2pSp2a8Fzw/oErlE+ykx0nZ/IVpxLdIBnun2Rmt11KJrab8SrOYXf5jeefIym98sGBjmXKNx1+ h9wZGwqMGmOCwnMDTIlJH2Lnfm/iifVhUr9tKKrOxF1uKrFR1c2D7tDYMAnLxdlbfJ/URDmUdsor2N UweTzqtLl97QqYBVJMbDlpZuV1XmgaQ== X-MHO-RoutePath: aGlwcGll X-MHO-User: 49b6675b-618e-11e9-919f-112c64a8cf29 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound4.ore.mailhop.org (Halon) with ESMTPSA id 49b6675b-618e-11e9-919f-112c64a8cf29; Thu, 18 Apr 2019 03:58:57 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x3I3wthg049245; Wed, 17 Apr 2019 21:58:55 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: svn commit: r346341 - head/tools/build From: Ian Lepore To: Cy Schubert , rgrimes@freebsd.org Cc: Cy Schubert , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Wed, 17 Apr 2019 21:58:55 -0600 In-Reply-To: <201904180332.x3I3WJTt096491@slippy.cwsent.com> References: <201904180332.x3I3WJTt096491@slippy.cwsent.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: DAE8E74953 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.991,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Apr 2019 03:59:01 -0000 On Wed, 2019-04-17 at 20:32 -0700, Cy Schubert wrote: > In message <201904180107.x3I17QDc002945@gndrsh.dnsmgr.net>, "Rodney > W. > Grimes" > writes: > > > Author: cy > > > Date: Thu Apr 18 01:02:00 2019 > > > New Revision: 346341 > > > URL: https://svnweb.freebsd.org/changeset/base/346341 > > > > > > Log: > > > As an interim measure until a more permanent solution is > > > implemented > > > workaround the following error: > > > > > > /usr/src/contrib/elftoolchain/strings/strings.c:198:55: error: > > > use of > > > undeclared identifier > > > 'FA_OPEN' fa = fileargs_init(argc, argv, O_RDONLY, 0, &rights, > > > FA_OPEN); > > > > > > Reported by: O. Hartmann > > > Reported by: Michael Butler > > > Reported by: gjb@ & cy@ (implicit) > > > Reviewed by: emaste@ > > > Noted by: rgrimes@ > > > > > > Modified: > > > head/tools/build/Makefile > > > > > > Modified: head/tools/build/Makefile > > > ================================================================= > > > ========== > > > > === > > > --- head/tools/build/Makefile Thu Apr 18 00:38:54 2019 ( > > > r34634 > > > > 0) > > > +++ head/tools/build/Makefile Thu Apr 18 01:02:00 2019 ( > > > r34634 > > > > 1) > > > @@ -59,9 +59,7 @@ INCS+= capsicum_helpers.h > > > INCS+= libcasper.h > > > .endif > > > > > > -.if !exists(/usr/include/casper/cap_fileargs.h) > > > CASPERINC+= ${SRCTOP}/lib/libcasper/services/cap_fileargs/c > > > ap_filea > > > > rgs.h > > > -.endif > > > > As a further note, we should probably hunt for any thing > > that is explicity looking at /usr/include/... in a Makefile, > > as that is minimally missing a ${DESTDIR} argument. > > > > The above may of actually worked if it had been written: > > .if !exists(${DESTDIR}/usr/include/casper/cap_fileargs.h) > > someone may wish to test that. > > > > Also a pathname rooted at / without ${DESTDIR} is almost certainly > > a mistake. > > This is a better solution. I tested this in a tree with a duplicated > environment: Problem solved. Before this is committed it should be > tested on one of the universe machines. > > I'm having a hard time understanding how adding $DESTDIR is any kind of solution to something that happens at build time as opposed to install time. I typically run buildworld/kernel without DESTDIR defined. -- Ian