From owner-svn-src-all@freebsd.org Thu Jan 18 22:15:19 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B9590EC6BD4; Thu, 18 Jan 2018 22:15:19 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670077.outbound.protection.outlook.com [40.107.67.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT SSL SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 69B96120D; Thu, 18 Jan 2018 22:15:18 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YTXPR0101MB2174.CANPRD01.PROD.OUTLOOK.COM (52.132.40.149) by YTXPR0101MB2173.CANPRD01.PROD.OUTLOOK.COM (52.132.40.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Thu, 18 Jan 2018 22:15:17 +0000 Received: from YTXPR0101MB2174.CANPRD01.PROD.OUTLOOK.COM ([fe80::b85e:6c21:ea28:5f9d]) by YTXPR0101MB2174.CANPRD01.PROD.OUTLOOK.COM ([fe80::b85e:6c21:ea28:5f9d%13]) with mapi id 15.20.0407.012; Thu, 18 Jan 2018 22:15:17 +0000 From: Rick Macklem To: Emmanuel Vadot , Emmanuel Vadot CC: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r328129 - head/sys/fs/nfsserver Thread-Topic: svn commit: r328129 - head/sys/fs/nfsserver Thread-Index: AQHTkHERZLAcPGgud0iNHWvuSowXEaN5xAOAgABtS1I= Date: Thu, 18 Jan 2018 22:15:16 +0000 Message-ID: References: <201801181528.w0IFSnWm053535@repo.freebsd.org>, <20180118163855.b0a55427709c52d0ec2482c9@bidouilliste.com> In-Reply-To: <20180118163855.b0a55427709c52d0ec2482c9@bidouilliste.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rmacklem@uoguelph.ca; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; YTXPR0101MB2173; 7:93H3fnRL2E3JV9CJBXbb0PF6ASXe3PPBa7wbn2hMcIK4L+wm1Uiyw+DpH+ZlZvASceVK6znePm9T9kFehaG4ozIrbAA79W8rHoHnmoPi1X5PrJEQtJGDhJoUetv1XrhsXsng4CI7brQtpmSQbYX+6ZrpASQAodWZxdCVCoU1dXxLey4UGaAFNbBtQLOAiHp4f6xCasua9OqRvso+BR6iNE62wnuPGMDTB6AEa+wZ0G9tyM9M/wE4rOa/3HGa+uGT x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 38118f6f-ff27-479f-695f-08d55ec0f46e x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989060)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:YTXPR0101MB2173; x-ms-traffictypediagnostic: YTXPR0101MB2173: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(56005881305849)(158342451672863); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231023)(2400067)(944501161)(3002001)(6041268)(20161123560045)(201703131423095)(201702281529075)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123562045)(6072148)(201708071742011); SRVR:YTXPR0101MB2173; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:YTXPR0101MB2173; x-forefront-prvs: 05568D1FF7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(396003)(376002)(366004)(39380400002)(39860400002)(189003)(199004)(8676002)(86362001)(81156014)(99286004)(68736007)(110136005)(8936002)(97736004)(105586002)(3280700002)(53936002)(2950100002)(106356001)(2906002)(25786009)(81166006)(6436002)(76176011)(74482002)(33656002)(786003)(316002)(5660300001)(4326008)(55016002)(478600001)(6506007)(305945005)(59450400001)(229853002)(5250100002)(102836004)(74316002)(14454004)(7696005)(54906003)(9686003)(6246003)(966005)(26005)(6306002)(2900100001)(3660700001); DIR:OUT; SFP:1101; SCL:1; SRVR:YTXPR0101MB2173; H:YTXPR0101MB2174.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-microsoft-antispam-message-info: 3XjKnMVhJ5kWfhlCegswUeIjrOMoJ0BuuVvISxjajxFwWZGvo7+cWY+mDmqV8uj91l473/Y8dQl3PiDqIr55hQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 38118f6f-ff27-479f-695f-08d55ec0f46e X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2018 22:15:17.0089 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTXPR0101MB2173 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2018 22:15:19 -0000 Emmanuel Vadot wrote: >> Author: manu >> Date: Thu Jan 18 15:28:49 2018 >> New Revision: 328129 >> URL: https://svnweb.freebsd.org/changeset/base/328129 >> >> Log: >> nfs: Do not printf each time a lock structure is freed during module u= nload >> >> There can be a lot of those structures and printing a line each time w= e free >> one on module unload. > > Finishing the sentence : > > There can be a lot of those structures and printing a line each time >we free one on module unload is really time consuming, especially when >you have a serial console plugged in. I will note that when I put a printf() like this in the code, it is becaus= e I consider it an abnormal occurrence. It might be better to at least print the message once. For this case, normally all lock structures should go away when clients unmount and unloading the nfsd module while there are active mounts is not a safe practice. (Again NFSv4 isn't like NFSv3, there is server stat= e for NFSv4.) rick