Date: Wed, 24 Apr 2013 15:21:54 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: Jimmy Olgeni <olgeni@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r316469 - head/databases/slony1v2 Message-ID: <517830D2.5060600@FreeBSD.org> In-Reply-To: <alpine.BSF.2.00.1304242105250.29749@olgeni.olgeni> References: <201304241850.r3OIovPc079999@svn.freebsd.org> <51782B87.2090000@FreeBSD.org> <alpine.BSF.2.00.1304242105250.29749@olgeni.olgeni>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 2013-04-24 15:08:00 -0400, Jimmy Olgeni wrote: > > On Wed, 24 Apr 2013, Jung-uk Kim wrote: > >> On 2013-04-24 14:50:57 -0400, Jimmy Olgeni wrote: >>> Author: olgeni Date: Wed Apr 24 18:50:57 2013 New Revision: >>> 316469 URL: http://svnweb.freebsd.org/changeset/ports/316469 >>> >>> Log: - Use bsd.port.options.mk. - PORTDOCS should not be >>> conditional. - Whitespace fix. >> ... >> >> bsd.port.mk says "(PORTDOCS) should not be set when no >> documentation files are installed" and I believe it is actually >> correct. > > I found this on the Porter's Handbook: > > If a directory is listed in PORTDOCS or matched by a glob pattern > from this variable, the entire subtree of contained files and > directories will be registered in the final packing list. If the > DOCS option has been unset then files and directories listed in > PORTDOCS would not be installed or added to port packing list. > > It seems to behave correctly, at least in the PORTDOCS=* case. It may work for now because bsd.options.mk has backward compat shim, i.e., ## Now some compatibility .if empty(PORT_OPTIONS:MDOCS) NOPORTDOCS= yes .endif It won't work when we deprecate the compat shims. Jung-uk Kim -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQEcBAEBAgAGBQJReDDSAAoJECXpabHZMqHOeMwIAM1VyJVz0QZCBHLZtxOgZPPN Pc5rAVb7NFzN6bh50MjmbM5zHZPzM/0zuGtqRu059TlfAmABJBJqrjhPkcnHHGHX coWBKZdOnGwhzaCGFU8SsVvntbyIQX1wO7OMkUbvDGnP/HLvBTQ0ybw81GOUa5Tz 921d0W1ZLTPIfonviV1H2TQWo+8Kbeh8/9H9IsQsJtQzqbh4rPzatiujEYuIIuqx GBjUAPOmuGQSrh3tmpvA19O4l0KjsVt2re5I8numPPwIhPWWCgPi7pTAEHLre5IW o7GyF9lu4zVZhjVz67HW5XT3mb0ZR0BeaBi61i2C6Q2DrZhywmM7DaKH4qsbcSc= =PWBI -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?517830D2.5060600>