From owner-freebsd-net Wed Dec 13 17:43:21 2000 From owner-freebsd-net@FreeBSD.ORG Wed Dec 13 17:43:18 2000 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from earth.backplane.com (placeholder-dcat-1076843399.broadbandoffice.net [64.47.83.135]) by hub.freebsd.org (Postfix) with ESMTP id EA65F37B698; Wed, 13 Dec 2000 17:43:17 -0800 (PST) Received: (from dillon@localhost) by earth.backplane.com (8.11.1/8.9.3) id eBE1hCx90268; Wed, 13 Dec 2000 17:43:12 -0800 (PST) (envelope-from dillon) Date: Wed, 13 Dec 2000 17:43:12 -0800 (PST) From: Matt Dillon Message-Id: <200012140143.eBE1hCx90268@earth.backplane.com> To: Alfred Perlstein Cc: Kirk McKusick , arch@FreeBSD.ORG, net@FreeBSD.ORG Subject: Re: patch to cleanup inflight desciptor handling. References: <200012131852.KAA17423@beastie.mckusick.com> <200012132106.eBDL6Sg86570@earth.backplane.com> <20001213141917.Q16205@fw.wintelcom.net> <20001213145341.S16205@fw.wintelcom.net> <20001213153649.T16205@fw.wintelcom.net> <200012140125.eBE1Pbi89951@earth.backplane.com> <20001213173103.B16205@fw.wintelcom.net> Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org :> No waste at all, Alfred, the file descriptor passing code had been : :Are you saying the code in place is broken? If so I'll spend some :time looking at it and the Linux implementation to figure if at :least one of us gets it right and try to find some sort of solution. No, *had*, not *has*. It isn't broken, just inefficient in certain cases due to the brute-force GC. :Obviously the easiest way would be to disallow passing of any :descriptors that have descriptors in thier socketbuffers. : :Since almost no one uses this code, and I hardly see a reason for :allowing that type of operation (passing af_unix fds with fds in :flight) it might be a good idea to just disallow that sort of :operation. : :It would definetly simplify and probably speed up the code. There's no reason to disallow that. Besides, any socket can be listen()'d after having been queued, so you aren't really preventing anything. -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message