From nobody Thu May 8 14:32:17 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZtZNB1kRnz5v8yR; Thu, 08 May 2025 14:32:26 +0000 (UTC) (envelope-from phil@juniper.net) Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.pphosted.com", Issuer "Sectigo RSA Organization Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZtZN92GWSz3MKY; Thu, 08 May 2025 14:32:25 +0000 (UTC) (envelope-from phil@juniper.net) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=juniper.net header.s=PPS1017 header.b=avZFmcfP; dkim=none ("invalid DKIM record") header.d=juniper.net header.s=selector1 header.b=Tx42d7Pv; spf=pass (mx1.freebsd.org: domain of phil@juniper.net designates 67.231.152.164 as permitted sender) smtp.mailfrom=phil@juniper.net; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=juniper.net Received: from pps.filterd (m0108162.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 548ATUUZ007851; Thu, 8 May 2025 07:32:24 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=PPS1017; bh=w/P+S+3umi0xl+bneIkrFvnV52 sEcw4/1FJnhjmNi5E=; b=avZFmcfP9SbRT1ZquIYf9EIKWPlHgyWv9XU5RuN4Q/ GP2rSRhAexRArU9vjbKqh/PLZDP915p/gUbDVc0YUNIYs/Hh0bo/F3jaVVzgZtki ekHOnoHVvvu5KmiEaPw/w0cwv7zRkePUKLbsQWMI0a7Vft73qOt/PlnwE0hS3s13 GlzL5npwJIuf7VTJAMJWFpz+FbZZi2lRoHrO+TAJ2rGWvrp+2QWdQEM1MsoA69WU 0yjG2w0qMqilfEnS4tD6kDp6msvB7y7dBUqUL15mnInBLgsdAdP1d+/KFzo46mtY IpkqTlAtaT5OkXwfBCptbSgbJvII4kZSoRg4sW3M1sRQ== Received: from bn1pr04cu002.outbound.protection.outlook.com (mail-eastus2azlp17010019.outbound.protection.outlook.com [40.93.12.19]) by mx0b-00273201.pphosted.com (PPS) with ESMTPS id 46gpses2v0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 08 May 2025 07:32:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NqHrtvdQQuiLP8vUhJWtnX/1yIizZ1oAi+bUlDeVTao22SAYSdjjNu3+BgQ/zqzoE041J7D5XioYRul5agy3BBiTRXTsCMvJpkIV9R67MYyiKZJLjv4qjK8u3p0piJYdw7MMs8oeILqMoZNzbRilE7Noh8exGqapryxiKPzdiMXlYU0FNtunOzpvo8nAZK9/PSdNvUuTsLeUEazVyNkEa/MeTmxR2e4ywSn4aS4Ic+Gc4xh7XG89dwtLCm6oBGyaVrq4/Os9XbnBBBbvzv+1TKF3o6s/m4JjSV4ttHb6xEpM2BZejUSlvs+PBXKp/iQjnQDG+ZmTYLeFFaVgtoxHkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w/P+S+3umi0xl+bneIkrFvnV52sEcw4/1FJnhjmNi5E=; b=qr4PTn5CQe32NnmX2TMI/cK18ZSQpObmNzXj4f/+jC6pH0alpn3TOGHeELO98d634QEXKw89HY/av/didarWtlILwSwmLMsckPEd+9U+8WQjyZ7tDsLQu9qTvwQEXLs2inoVax29KKz9dy2/xFjRum5tMhZMJA+74XncJU+6JuZ/OGtBhC/61Vg4qKbXXCdFTu6bgjDwa5ybqq3vMJyKH4ngi/7cEfwwaLKqBKgoWykF++IzV/dGE56B4LHGYuL/+gT7KhY7rCu015zinZ/u/y0QcKWXOWdK4b3CD44jFudQYJ0PkMUyv1ui66ZV9m1w2giMaeBX9fBGq8qtGbyqFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 66.129.239.14) smtp.rcpttodomain=freebsd.org smtp.mailfrom=juniper.net; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=juniper.net; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w/P+S+3umi0xl+bneIkrFvnV52sEcw4/1FJnhjmNi5E=; b=Tx42d7PvVwEYGDqn6fvqH+blUnCd6w9D4RUrHVmigsllpO0jeHzlMYhBO1Kh/evJORy/nW9Efnl6kqlfpX2hg3YOixkTQh+mmH2JDgRnCS6OOiGDBRnmS4vv9FB9Yr1ffdZm/jLIKW+5BvLnGr5Gub09i85pVct3EGa84NKvKH8= Received: from DM5PR08CA0044.namprd08.prod.outlook.com (2603:10b6:4:60::33) by PH0PR05MB8560.namprd05.prod.outlook.com (2603:10b6:510:c7::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.23; Thu, 8 May 2025 14:32:20 +0000 Received: from DS1PEPF00017099.namprd05.prod.outlook.com (2603:10b6:4:60:cafe::bf) by DM5PR08CA0044.outlook.office365.com (2603:10b6:4:60::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8655.42 via Frontend Transport; Thu, 8 May 2025 14:32:20 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 66.129.239.14) smtp.mailfrom=juniper.net; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=juniper.net; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.14 as permitted sender) Received: from p-exchfe-eqx-01.jnpr.net (66.129.239.14) by DS1PEPF00017099.mail.protection.outlook.com (10.167.18.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.18 via Frontend Transport; Thu, 8 May 2025 14:32:20 +0000 Received: from p-exchbe-eqx-02.jnpr.net (10.104.9.15) by p-exchfe-eqx-01.jnpr.net (10.104.9.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 8 May 2025 09:32:19 -0500 Received: from p-mailhub01.juniper.net (10.104.20.6) by p-exchbe-eqx-02.jnpr.net (10.104.9.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14 via Frontend Transport; Thu, 8 May 2025 09:32:19 -0500 Received: from idleski.juniper.net (idleski.juniper.net [172.25.4.10]) by p-mailhub01.juniper.net (8.14.4/8.11.3) with ESMTP id 548EWIxh017864; Thu, 8 May 2025 07:32:19 -0700 (envelope-from phil@juniper.net) Received: from [10.0.0.3] (localhost [127.0.0.1]) by idleski.juniper.net (8.16.1/8.16.1) with ESMTP id 548BG2RR065088; Thu, 8 May 2025 07:16:02 -0400 (EDT) (envelope-from phil@juniper.net) From: Phil Shafer To: Warner Losh CC: , , Subject: Re: git: c759aca606ce - main - devinfo: Add support for libxo Date: Thu, 8 May 2025 10:32:17 -0400 X-Mailer: MailMate (1.14r5937) Message-ID: <0F9E0431-84E0-46E2-B28F-99F5A7DB70C5@juniper.net> In-Reply-To: <202505062202.546M2O1b042545@gitrepo.freebsd.org> References: <202505062202.546M2O1b042545@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017099:EE_|PH0PR05MB8560:EE_ X-MS-Office365-Filtering-Correlation-Id: 5aec8203-8a7a-4eeb-5876-08dd8e3d2416 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?MAzJI6JwGXZ9646oqiLSDYCmysMIYlxXKCl10v0xZJD2GElblXPogBDrjW+9?= =?us-ascii?Q?NohvS+tBZ+vfL7H+dnznPcIAKsN8CxiqVjMo/COPDQi9U8I3nEwvi6KQRFcZ?= =?us-ascii?Q?K6fT7/pYOAmsvYvHV1A3wJnPjVyg6ExSgcQEphpjasHKdc3H8b5pnz9bJed7?= =?us-ascii?Q?dAwERaF3ZJyMfAI+SLv9jjIZFYqV0s7wh3BdaIff2i0XYwWqwoU7FfzI9mf6?= =?us-ascii?Q?kGHKBf3VnSna8q+rM7g8PgAdCntIUtlYYADA4T3hpBljjIhKYf69ieGN938a?= =?us-ascii?Q?Og1NO6FVibIy7hETFSWi1tafHIZl4a65DCjmSGOotFJsnyr1RMw4lUglar00?= =?us-ascii?Q?zmkHFPiTFiXW9360rpauKk0Q5JFlArayjmVu9PFoPhKgRQsGjo4rH8LFi50B?= =?us-ascii?Q?stUD1qh1z0Ypm1v4tS4Mj/BnTAFteNVdE5MPnXdisZFNdfU5On+Ss8T83THe?= =?us-ascii?Q?BF68RJ+Cmio3NMLvNoYc9TA2yP5qSVeLS9McxCOIHwOwSQ894vUuw02maVXn?= =?us-ascii?Q?ZelXtPhPYZoHm+D+QO+SLN9H3SaARXXJgCbC+TlzF6qulucMS6czWJQk+0Zt?= =?us-ascii?Q?J29gEl3B1bzmwp+8dM5HCU6SH1M/hegWlJXTB11bWBT/ZTQaV19z1KA1hgLm?= =?us-ascii?Q?U4uqaYgF5dkf3kPi+HFJ+kXsNY96Da5vmKwTi2bLWbnUIxd8BZgPflMkYtO5?= =?us-ascii?Q?VRkB7ZfVPiY8YxYPq0azaJyG7hET2aq8b0tCKvKLkq2jczGCO6KEIsjwQlMZ?= =?us-ascii?Q?UzhX8mkG/e2sGlz0Fw0dTDCqQd56zSh/wLO0yROiSfSmU9BgUbPAHTgp9PdK?= =?us-ascii?Q?eR46bdq4lCQq9Rk4kYgwrI+mPYCIQRIOhaaUx9tv7oatexOJePIrbwxvjqaN?= =?us-ascii?Q?OAjitvs/52j8e7MLngj/TK7KhppEZ4VoRR3IHqJL4XN+qUowVY8Z5UWSycqG?= =?us-ascii?Q?T4Mxi1QP8Z+z2Zw4OgX+UYj9bcZN8LQUa3afwDbyo3m3kfN5aQtz7Dqun0C2?= =?us-ascii?Q?9BL1zDj4J/sXHgdxALoZrfy/QMYvZaRYD5G3h4URxKhDa/yWulLF360pwlbQ?= =?us-ascii?Q?s8FbRuHGLa4wqDF4fQNvNvQOYqNd1A1tVmZWrICEj6JA8J5VA4V7q6xHqiZ3?= =?us-ascii?Q?GLtWz9Yjw4xtOVxbfW6DC5gDIuzuVz7yBhMljaSdlGPt/p1LuC3AyYCkJD1J?= =?us-ascii?Q?QhDsyaRBJGO5mydhFty1mdClrXf61G1HUA+DAKdjkUvUsfAfeK0SBe7dejCI?= =?us-ascii?Q?Y6AXsqWClW2/5pzpSWQ3GEMscwnMcucjG01cE58fB3VUI42zgVqEzvS3Jexz?= =?us-ascii?Q?O6V8AaDzdo1dH814ilHBEvhTedUo2LkYBwiSayELkTQBRp6tW7PvPV58IcQH?= =?us-ascii?Q?OFJH8IfiyrXNh+0kIeB2b+IvniJrChFc/mLtbG8nFePKn4NE31i5SF5bFR8g?= =?us-ascii?Q?WNYzzkiBHEs18b7qeM/8vLYshVLpFTWTMyfc2+7s4k2hfNFBr3PzSqw6w8dI?= =?us-ascii?Q?nK109ZJN26DcYdq0rx5Zt6R4WVivw05PFTB+?= X-Forefront-Antispam-Report: CIP:66.129.239.14;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:p-exchfe-eqx-01.jnpr.net;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014);DIR:OUT;SFP:1102; X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2025 14:32:20.5177 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5aec8203-8a7a-4eeb-5876-08dd8e3d2416 X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4;Ip=[66.129.239.14];Helo=[p-exchfe-eqx-01.jnpr.net] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017099.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR05MB8560 X-Proofpoint-ORIG-GUID: P0rX3HhjMwpkjJU8_1MvOmFUZv035Rln X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA4MDEyNCBTYWx0ZWRfX+hByp2wXXHBI 8vHVwGY9yomjC3B6LFagw5zNnZfJzjJlWKi0W6jpa0OgCtqczdTHuiOBg1dnuPN0WCKQmItbWz8 aEpgRhGiaUjlLmiVHHcocWSbIZIKje1anq8o8jJRuP/2GyINJV6Zhqf6F56WwNcAkwlK2wd5GyU 6ZxuNdWDAIxHmjQChWnXq8Hn5TJhzJ1t0bjlKyvo2eDHSR5DLznR7qiclWnxpwZwnESuXmxrqJy Y/6BrctZi60BuGyQPRkrGZ32MlLBlZSCH1zeReWpS1y+8VgJarIVrXHqb3amlJCjD7u5YLPRekb LkSWd0qOkAKtoRV7gIW1Uz+L2GhtpfjLW/+cbF+gmrSWj+FEsrugu9hLvvWsCZh9fLm/Zp25qvr HZobnJF1m/jnyT2CT6tg5l5Cre8SIsnLwxt5q9hEYKdgJv5DMngzZdayCpALXF0w1OWruAHl X-Proofpoint-GUID: P0rX3HhjMwpkjJU8_1MvOmFUZv035Rln X-Authority-Analysis: v=2.4 cv=TdKWtQQh c=1 sm=1 tr=0 ts=681cc078 cx=c_pps a=b4GTUaH8bIYRMqSiyTmTYA==:117 a=f/rncuQqEjTEF/G1odkJ9w==:17 a=h8e1o3o8w34MuCiiGQrqVE4VwXA=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=dt9VzEwgFbYA:10 a=s63m1ICgrNkA:10 a=rhJc5-LppCAA:10 a=XSr2-R0Gb8Nm4hJX0XcA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-08_05,2025-05-07_02,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 clxscore=1011 adultscore=0 malwarescore=0 bulkscore=0 mlxlogscore=806 suspectscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 mlxscore=0 phishscore=0 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2505080124 X-Rspamd-Queue-Id: 4ZtZN92GWSz3MKY X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.41 / 15.00]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector10001:i=1]; NEURAL_HAM_LONG(-0.99)[-0.986]; NEURAL_HAM_MEDIUM(-0.93)[-0.927]; DMARC_POLICY_ALLOW(-0.50)[juniper.net,reject]; NEURAL_HAM_SHORT(-0.40)[-0.399]; R_DKIM_ALLOW(-0.20)[juniper.net:s=PPS1017]; R_SPF_ALLOW(-0.20)[+ip4:67.231.152.164]; RCVD_IN_DNSWL_LOW(-0.10)[67.231.152.164:from]; MIME_GOOD(-0.10)[text/plain]; R_DKIM_PERMFAIL(0.00)[juniper.net:s=selector1]; ASN(0.00)[asn:22843, ipnet:67.231.152.0/24, country:US]; FREEFALL_USER(0.00)[phil]; RCVD_IN_DNSWL_NONE(0.00)[40.93.12.19:received]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; DKIM_TRACE(0.00)[juniper.net:+,juniper.net:~]; MID_RHS_MATCH_FROM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; DKIM_MIXED(0.00)[]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org,dev-commits-src-all@freebsd.org]; RCVD_COUNT_SEVEN(0.00)[9] On 6 May 2025, at 18:02, Warner Losh wrote: > xo_emit(" <{d:%s}>", dev->dd_desc); Missing the field name and the "/". With "--libxo:W", you should see "foo: invalid XML tag name: '%s'". Annoying, 'xolint' does not catch this. + xo_emit(" <{d:%s}>", dev->dd_desc); + xo_emit("{e:description/%s}", dev->dd_desc); I'm not sure why you need both lines here, given that: xo_emit("<{:description/%s}>", dev->dd_desc); should suffice, since the "encoding" styles will not emit the surrounding text: % cat /tmp/foo.c #include int main (int argc, char **argv) { xo_parse_args(argc, argv); xo_open_container("data"); xo_emit(" <{:description/%s}>\n", argv[0]); xo_close_container(NULL); xo_finish(); return 0; } % /tmp/foo % /tmp/foo --libxo:XPW /tmp/foo % /tmp/foo --libxo:JPW { "data": { "description": "/tmp/foo" } } % The same issue ("{d:%s}") is repeated in print_rman, etc. + if (xo_finish() < 0) { + exit(1); } return(0); Should I make a more convenient form, so one can just: return xo_finish_rc(); /* xo_finish_exit_code()? */ Thanks, Phil