From owner-freebsd-bugs  Mon Jun  2 20:50:03 1997
Return-Path: <owner-bugs>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id UAA01406
          for bugs-outgoing; Mon, 2 Jun 1997 20:50:03 -0700 (PDT)
Received: (from gnats@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id UAA01400;
          Mon, 2 Jun 1997 20:50:01 -0700 (PDT)
Resent-Date: Mon, 2 Jun 1997 20:50:01 -0700 (PDT)
Resent-Message-Id: <199706030350.UAA01400@hub.freebsd.org>
Resent-From: gnats (GNATS Management)
Resent-To: freebsd-bugs
Resent-Reply-To: FreeBSD-gnats@FreeBSD.ORG, denny1@home.com
Received: (from nobody@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id UAA01161;
          Mon, 2 Jun 1997 20:40:05 -0700 (PDT)
Message-Id: <199706030340.UAA01161@hub.freebsd.org>
Date: Mon, 2 Jun 1997 20:40:05 -0700 (PDT)
From: denny1@home.com
To: freebsd-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: www-1.0
Subject: bin/3766: ping has a few missing ntohs() & ntohl()
Sender: owner-bugs@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk


>Number:         3766
>Category:       bin
>Synopsis:       ping has a few missing ntohs() & ntohl()
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun  2 20:50:00 PDT 1997
>Last-Modified:
>Originator:     Denton Gentry
>Organization:
>Release:        FreeBSD-current as of 6/2/97
>Environment:
no FreeBSD machine
>Description:
  ping.c is missing a few ntohs/ntohl wrappers around fields in the
more obscure icmp codes.
>How-To-Repeat:
  Found by source inspection while working on ping for OpenBSD.
>Fix:
943c943
<                                       ntohs(icp->icmp_nextmtu));
---
>                                       icp->icmp_nextmtu);
989c989
<               (void)printf("(New addr: 0x%08lx)\n", ntohl(icp->icmp_gwaddr.s_addr));
---
>               (void)printf("(New addr: 0x%08lx)\n", icp->icmp_gwaddr.s_addr);
>Audit-Trail:
>Unformatted: