From owner-freebsd-net@FreeBSD.ORG Fri Jun 12 14:30:05 2009 Return-Path: Delivered-To: freebsd-net@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4BD83106566C; Fri, 12 Jun 2009 14:30:05 +0000 (UTC) (envelope-from gallatin@cs.duke.edu) Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) by mx1.freebsd.org (Postfix) with ESMTP id 06B218FC1B; Fri, 12 Jun 2009 14:30:04 +0000 (UTC) (envelope-from gallatin@cs.duke.edu) Received: from [172.31.193.10] (cpe-075-177-134-250.nc.res.rr.com [75.177.134.250]) (authenticated bits=0) by duke.cs.duke.edu (8.14.2/8.14.2) with ESMTP id n5CDUnCW004021 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 12 Jun 2009 09:31:41 -0400 (EDT) X-DKIM: Sendmail DKIM Filter v2.8.3 duke.cs.duke.edu n5CDUnCW004021 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=cs.duke.edu; s=mail; t=1244813502; bh=UizV9K0br7D4KVaB/Sr78m2lDuu6Ue5krfIKkJru49A=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=VEJ+VCFk7RQEI0cNCTiF3W4twg2HL+MxEk4MNkfXHo1sRd8c6zyv+CuLmzRTVDct9 sN8Fl2OS0pLFsQ3aQsmmkamXd86BDGmR3RTXm029C5GBwWbasPR5Ya9gxxNt+zTM+f XIt7pB5ner8Z8ByVTsSlFjHQU4RvCMijfz40eWjI= Message-ID: <4A325883.3050206@cs.duke.edu> Date: Fri, 12 Jun 2009 09:30:43 -0400 From: Andrew Gallatin User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: "Bjoern A. Zeeb" References: <20090611184555.J22887@maildrop.int.zabbadoz.net> In-Reply-To: <20090611184555.J22887@maildrop.int.zabbadoz.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: FreeBSD net mailing list Subject: Re: Ethernet NIC drivers depending unconditionally on INET X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jun 2009 14:30:05 -0000 Bjoern A. Zeeb wrote: > if_mxge: > ---------------------------------------- > mxge_rx_csum() has one in_pseudo(). The function and callers > already seem to know how do deal with results in case the csum can't > be validated. So this should be a simple #ifdef INET wrapping here; > side note: the tcpudp_csum variables in the callers are not needed. > side note: huge inlining going on there;) > mxge_lro_flush() has another call to in_pseudo(). As with if_igb/ixgbe Thanks for pointing those out. It will be a few days before I've got time to deal with it properly. If you don't see me commit a fix within a week, please remind me. > if there is no INET there should be no LRO for now, the capabilities > not advertised, etc. Be prepared in case LRO will arrive for IPv6. As to LRO & IPV6... I was going to port our LRO for IPv6, but discovered the state of IPv6 in FreeBSD is so disgraceful that there was no point. Eg, there is no checksum offload, no TSO, etc, for INET6. Once those things are there, I'll be happy to provide LRO for IPv6. Drew