From owner-freebsd-ports-bugs@freebsd.org Thu Jan 10 11:22:06 2019 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B30951487453 for ; Thu, 10 Jan 2019 11:22:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 4D751776F5 for ; Thu, 10 Jan 2019 11:22:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 0B2811487451; Thu, 10 Jan 2019 11:22:06 +0000 (UTC) Delivered-To: ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DCC46148744E for ; Thu, 10 Jan 2019 11:22:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 63FF0776F0 for ; Thu, 10 Jan 2019 11:22:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id A51CD1CBD9 for ; Thu, 10 Jan 2019 11:22:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x0ABM4DA036018 for ; Thu, 10 Jan 2019 11:22:04 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x0ABM4jx036017 for ports-bugs@FreeBSD.org; Thu, 10 Jan 2019 11:22:04 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 234817] databases/pgpool-II-40: Broken PAM option? Date: Thu, 10 Jan 2019 11:22:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tobik@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tz@freebsd.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter cc flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 11:22:07 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234817 Bug ID: 234817 Summary: databases/pgpool-II-40: Broken PAM option? Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: tz@freebsd.org Reporter: tobik@freebsd.org CC: tz@freebsd.org Assignee: tz@freebsd.org Flags: maintainer-feedback?(tz@freebsd.org) Attachment #200981 maintainer-approval?(tz@freebsd.org) Flags: CC: tz@freebsd.org Created attachment 200981 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D200981&action= =3Dedit pgpool-II-40.diff This has been raised on ports-committers before for ports r485048, but was ignored so far. I am filing this bug so that this is not lost. Since I have cleaned up some ports where variables are set twice, introducing all sort of problems, over the last couple of days, this has come up again. pgpool-II-40 does the following with the PAM and SSL options: SSL_CONFIGURE_WITH=3D openssl=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20 SSL_USES=3D ssl=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20 .include =20=20 .if ${PORT_OPTIONS:MPAM}=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20 #CONFIGURE_ARGS+=3D --with-pam=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20 SSL_CONFIGURE_WITH=3D pam=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20 .endif=20=20=20=20=20 Here SSL_CONFIGURE_WITH is set twice and seems to be tangled up with the PAM option in a way that does not make much immediate sense. For starters, it does not make sense to set an options helper after including bsd.port.options.mk. It is an artifact of how make(1) process variables, and how SSL_CONFIGURE_WITH was defined before including bsd.port.options.mk as well, that this actually does something here, i.e. add --with-pam to CONFIGURE_ARGS. The PAM option currently does nothing without the SSL option turned on. If this entanglement is correct (I do not think it is) then at the very least a PAM_IMPLIES=3DSSL is missing. I'm attaching a patch that hopefully cleans this up. --=20 You are receiving this mail because: You are the assignee for the bug.=