From nobody Wed Feb 11 02:07:06 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f9hdQ6wGDz6RZC9 for ; Wed, 11 Feb 2026 02:07:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f9hdQ4Tncz3y4n for ; Wed, 11 Feb 2026 02:07:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770775626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=//6G8dyRKAy2MJoi6eRfOehdHM/qY7Lm/KEOwnYIego=; b=NGvdGZxp+pyjLTHxqz1w0DwIa19JxnDqnE6oar6q8uqT7psUvzj80soOWXx2mHbKMvrDkG tF1gNPQiuIaO92kFzJMdzkpi/JeGGogHSyiZSpXO4sAgIBCMHTHCfcJ8y/QyOvADF0uhiB xJa1cgSWgb50YKjhoOT/wRuBhzokZz8AnR7tuFdFoeJomO81yTTaz3/965n57U1VLCcGy2 RxPg37etbg88MeJUlL8y4TBu365orqwHeojeDgSlzQFIIHSuLX7TTqKQ18MdTxvDHZ5AeH 5wplDmHhBSMXaDOXza7CD0vfw0Zq8cMVE9zYgmz74c+nYappkioGHLkLT3+q2w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770775626; a=rsa-sha256; cv=none; b=QxQYcO+yiWHyxQSbdI4rPJqzYjTeB1z0gRnqBvrapw34/kCqjJ+08LkoIcpwYQkOaLbxqO pBVZt1gHNhKnhTcMW/xIZ43NMM6B4N2YL8c1882sinBQ0VsECNkKg1+UfsfYvc7TU63jkk Wr4ounCqGypfIBFhgyO/GhCTzXPLEbtVUvajZKthIFlT53LGvMDF8o5FKauY8ywe4jANzA 1WIuCjcHPLPdAsNwj1RGWziRuyQVxp2IB//NMsM9xJtyvMohgYfSDPDCwG2IZZaBCAncbu sMmDr2uUoreHlPZQfxqfFgS/zm9WXLYLZEBOsv7d27rwWnh0G0MJM3uYg0zwvQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770775626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=//6G8dyRKAy2MJoi6eRfOehdHM/qY7Lm/KEOwnYIego=; b=W8LvEFrXahrtqUzZ5qPM/TAE+6MVA9BxwUWVasLS0XoGt9VMy3yT98o5xrOtjRDN/pG7QX Qj247BI7f+x5w1QFZW7TClac/wKtChYu0zxh0iwDo2Zwr8WASK/xPg0Y2bmr5vlS2KOgzv 7Zlr16gBBTtfaggnIqEWxXJnujBllkPNb8drLBdJRDAavbi9XkiJSA4O9Oo1oHj/g2inJh G8XfdKzvvySUAx7D7675rX99++nmOH7bA/jwppYXtApxWDZtYxv45DkKN2qzyqOdg+i6D+ sFZfq1E1R8noNobyEHWYKhMwsQLWrlENrzvRh7LlH2NVWlGigm0fxJ72UQ219w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f9hdQ3tbCzTgS for ; Wed, 11 Feb 2026 02:07:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 41eae by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 11 Feb 2026 02:07:06 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 5b398611607b - main - pwd: Error out if writing to stdout failed List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5b398611607b0dab2f2550ef73f62d41dab6fac5 Auto-Submitted: auto-generated Date: Wed, 11 Feb 2026 02:07:06 +0000 Message-Id: <698be44a.41eae.119893e7@gitrepo.freebsd.org> The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=5b398611607b0dab2f2550ef73f62d41dab6fac5 commit 5b398611607b0dab2f2550ef73f62d41dab6fac5 Author: Dag-Erling Smørgrav AuthorDate: 2026-02-11 02:06:41 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-02-11 02:06:56 +0000 pwd: Error out if writing to stdout failed POSIX requires us to print a diagnostic and return a non-zero exit code if writing to stdout failed. MFC after: 1 week Sponsored by: Klara, Inc. Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D55227 --- bin/pwd/pwd.c | 2 ++ bin/pwd/tests/pwd_test.sh | 21 +++++++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/bin/pwd/pwd.c b/bin/pwd/pwd.c index f626a2236c02..2bbf5457ec17 100644 --- a/bin/pwd/pwd.c +++ b/bin/pwd/pwd.c @@ -112,5 +112,7 @@ main(int argc, char *argv[]) printf("%s\n", pwd); else err(1, "."); + if (fflush(stdout) != 0) + err(1, "stdout"); exit(0); } diff --git a/bin/pwd/tests/pwd_test.sh b/bin/pwd/tests/pwd_test.sh index e418e56a89fa..a8805582cc4d 100644 --- a/bin/pwd/tests/pwd_test.sh +++ b/bin/pwd/tests/pwd_test.sh @@ -66,8 +66,29 @@ physical_body() atf_check -o inline:"$root/phy/baz\n" pwd -L } +atf_test_case stdout +stdout_head() +{ + atf_set descr "error writing to stdout" +} +stdout_body() +{ + pwd=$(which pwd) + [ -f "$pwd" ] || atf_skip "unable to distinguish binary from builtin" + ( + trap "" PIPE + # Give true(1) some time to exit. + sleep 1 + $pwd 2>stderr + echo $? >result + ) | true + atf_check -o inline:"1\n" cat result + atf_check -o match:"stdout" cat stderr +} + atf_init_test_cases() { atf_add_test_case logical atf_add_test_case physical + atf_add_test_case stdout }