From owner-cvs-ports@FreeBSD.ORG Sun Dec 31 19:10:19 2006 Return-Path: X-Original-To: cvs-ports@FreeBSD.org Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A3FDA16A415 for ; Sun, 31 Dec 2006 19:10:19 +0000 (UTC) (envelope-from alepulver@FreeBSD.org) Received: from relay00.pair.com (relay00.pair.com [209.68.5.9]) by mx1.freebsd.org (Postfix) with SMTP id 4C10513C457 for ; Sun, 31 Dec 2006 19:10:19 +0000 (UTC) (envelope-from alepulver@FreeBSD.org) Received: (qmail 49105 invoked by uid 0); 31 Dec 2006 19:10:17 -0000 Received: from 200.115.252.195 (HELO phobos.mars.bsd) (200.115.252.195) by relay00.pair.com with SMTP; 31 Dec 2006 19:10:17 -0000 X-pair-Authenticated: 200.115.252.195 Date: Sun, 31 Dec 2006 16:09:46 -0300 From: Alejandro Pulver To: pav@FreeBSD.org Message-ID: <20061231160946.71e9cd55@phobos.mars.bsd> In-Reply-To: <1167590824.1320.52.camel@ikaros.oook.cz> References: <200612310434.kBV4YRXS037540@repoman.freebsd.org> <1167575429.1320.24.camel@ikaros.oook.cz> <20061231133753.4156b868@phobos.mars.bsd> <1167584645.1320.33.camel@ikaros.oook.cz> <20061231150344.25871955@phobos.mars.bsd> <1167590824.1320.52.camel@ikaros.oook.cz> X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.10.6; i386-portbld-freebsd6.1) Mime-Version: 1.0 Content-Type: multipart/signed; boundary=Sig_Dl2uozbaUuJiUfGORrLx5z_; protocol="application/pgp-signature"; micalg=PGP-SHA1 Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.wx.mk X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Dec 2006 19:10:19 -0000 --Sig_Dl2uozbaUuJiUfGORrLx5z_ Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable On Sun, 31 Dec 2006 19:47:04 +0100 Pav Lucistnik wrote: > Alejandro Pulver p=ED=B9e v ne 31. 12. 2006 v 15:03 -0300: > > On Sun, 31 Dec 2006 18:04:05 +0100 > > Pav Lucistnik wrote: > >=20 > > > Alejandro Pulver p=ED=B9e v ne 31. 12. 2006 v 13:37 -0300: > > > > On Sun, 31 Dec 2006 15:30:29 +0100 > > > > Pav Lucistnik wrote: > > > >=20 > > > > > > - Remove _WX_ILLEGAL_VERS_* added in the last update to 2.8. = The reason is > > > > > > that each port should choose the version it can use, that i= ncludes taking > > > > > > into account available components (also this brings much mo= re chicken and > > > > > > egg problems so the code could get really messy). > > > > >=20 > > > > > I have reverted this. It's needed as long as you want to let peop= le use > > > > > ranges like 2.4+ together with python component, etc. > > > > >=20 > > > >=20 > > > > It is complex to do that (if you want to do it the right way), beca= use > > > > you need to parse components and dependencies before selecting a > > > > version. The current code is wrong since it will only reject compon= ents > > > > without dependency type specifications (and if there were dependenc= ies > > > > then it will also ignore them). > > > >=20 > > > > I think people should select the versions that actually work with t= he > > > > port, that's why the version specification string is so flexible. > > > >=20 > > > > Also, if versions with invalid components are removed then the repo= rted > > > > error if a user writes USE_WX=3D2.4 and WX_COMPS=3Dsvg would be "se= lected a > > > > null or invalid WxWidgets version" instead of "selected a WxWidgets > > > > component (${_WX_COMP}) which is not available for the selected ver= sion > > > > (${_WX_VER})". > > >=20 > > > That can be done, I'm confident. > > >=20 > >=20 > > Yes, but it will remove flexibility in some way: > >=20 > > Currently the version is processed independently from the components. > > The first one is done in or in if > > WX_PREMK is defined (for ports like "x11-toolkits/py-wxPython26"). And > > the second one is always checked in . > >=20 > > If I make the version to depend on the components, then when USE_PREMK > > is defined, the port won't be able to modify WX_COMPS after > > (because the components can alter the version, and if > > then the port will think it's using one, but other will be used). >=20 > Is this the problem with upcoming rollout of bsd.options.mk ? >=20 > I mean, do you need to change WX_COMPS after bsd.port.pre.mk except when > handling OPTIONS and WITH_* flags? >=20 No at least when the port checks variables defined after , like ${ARCH}. Best Regards, Ale --Sig_Dl2uozbaUuJiUfGORrLx5z_ Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFFmAsCiV05EpRcP2ERAu4FAJkBR/LD7OFpJYRhb2xJtQLe68HlHACgsRFo nUQCooRb8u1X+IAbjNjWHMg= =T2cS -----END PGP SIGNATURE----- --Sig_Dl2uozbaUuJiUfGORrLx5z_--