Skip site navigation (1)Skip section navigation (2) 
Date:      Sat, 01 Jun 2019 23:06:25 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 238284] math/z3: compile warnings on non-x86 systems
Message-ID:  <bug-238284-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238284

            Bug ID: 238284
           Summary: math/z3: compile warnings on non-x86 systems
           Product: Ports & Packages
           Version: Latest
          Hardware: arm64
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: arrowd@FreeBSD.org
          Reporter: jfc@mit.edu
          Assignee: arrowd@FreeBSD.org
             Flags: maintainer-feedback?(arrowd@FreeBSD.org)

Building math/z3 on arm64 generates a lot of warnings, some of which are re=
al
bugs.  z3 is required by llvm-devel.

src/util/statistics.cpp
c++: warning: argument unused during compilation: '-msse'
[-Wunused-command-line-argument]
c++: warning: argument unused during compilation: '-msse2'
[-Wunused-command-line-argument]

The above is repeated for every file.  My ARM CPU does not have SSE or SSE2=
.  I
suspect the culprit is scripts/mk_util.py function test_fpmath, which reque=
sts
SSE flags unless they make the compiler return a non-zero exit code.

--- api/z3_replayer.o ---
../src/api/z3_replayer.cpp:172:19: warning: result of comparison of constan=
t -1
with expression of type 'char' is always false
[-Wtautological-constant-out-of-range-compare]
            if (c =3D=3D EOF) {
                ~ ^  ~~~
../src/api/z3_replayer.cpp:417:19: warning: result of comparison of constan=
t -1
with expression of type 'char' is always false
[-Wtautological-constant-out-of-range-compare]
            if (c =3D=3D EOF)
                ~ ^  ~~~

--- parsers/util/scanner.o ---
../src/parsers/util/scanner.cpp:65:35: warning: result of comparison of
constant -1 with expression of type 'char' is always false
[-Wtautological-constant-out-of-range-compare]
        if (delimiter =3D=3D ch || -1 =3D=3D ch) {
                               ~~ ^  ~~
../src/parsers/util/scanner.cpp:76:16: warning: result of comparison of
constant -1 with expression of type 'char' is always false
[-Wtautological-constant-out-of-range-compare]
        if (ch =3D=3D EOF) {
            ~~ ^  ~~~
../src/parsers/util/scanner.cpp:191:24: warning: result of comparison of
constant -1 with expression of type 'char' is always false
[-Wtautological-constant-out-of-range-compare]
                if (ch =3D=3D EOF) {
                    ~~ ^  ~~~
../src/parsers/util/scanner.cpp:249:35: warning: result of comparison of
constant -1 with expression of type 'char' is always false
[-Wtautological-constant-out-of-range-compare]
        if (ch =3D=3D delimiter || ch =3D=3D EOF) {
                               ~~ ^  ~~~
4 warnings generated.

../src/smt/mam.cpp:97:36: warning: result of comparison of constant -1 with
expression of type 'char' is always false
[-Wtautological-constant-out-of-range-compare]
            if (m_lbl2hash[lbl_id] =3D=3D -1) {
                ~~~~~~~~~~~~~~~~~~ ^  ~~
../src/smt/mam.cpp:108:35: warning: result of comparison of constant -1 with
expression of type 'const char' is always true
[-Wtautological-constant-out-of-range-compare]
                if (m_lbl2hash[i] !=3D -1) {
                    ~~~~~~~~~~~~~ ^  ~~

These say the programmer never imagined that type char could be unsigned.

--=20
You are receiving this mail because:
You are the assignee for the bug.=

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-238284-7788>