From owner-cvs-src@FreeBSD.ORG  Tue Apr 25 23:33:25 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EF61B16A400;
	Tue, 25 Apr 2006 23:33:25 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8E7B143D45;
	Tue, 25 Apr 2006 23:33:25 +0000 (GMT) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost.village.org [IPv6:::1] (may be forged))
	by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k3PNWaJp023790;
	Tue, 25 Apr 2006 17:32:39 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Tue, 25 Apr 2006 17:32:36 -0600 (MDT)
Message-Id: <20060425.173236.74726638.imp@bsdimp.com>
To: scottl@samsco.org
From: Warner Losh <imp@bsdimp.com>
In-Reply-To: <444E7BFE.4040800@samsco.org>
References: <444E7750.206@samsco.org> <200604251540.00170.jhb@freebsd.org>
	<444E7BFE.4040800@samsco.org>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org,
	jhb@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/bce if_bcereg.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Apr 2006 23:33:26 -0000

From: Scott Long <scottl@samsco.org>
Subject: Re: cvs commit: src/sys/dev/bce if_bcereg.h
Date: Tue, 25 Apr 2006 13:43:58 -0600

> John Baldwin wrote:
> > On Tuesday 25 April 2006 15:24, Scott Long wrote:
> > 
> >>John Baldwin wrote:
> >>
> >>>jhb         2006-04-25 19:18:48 UTC
> >>>
> >>>  FreeBSD src repository
> >>>
> >>>  Modified files:
> >>>    sys/dev/bce          if_bcereg.h 
> >>>  Log:
> >>>  Fix half of the current i386 tinderbox failure.  max_bus_addr should be a
> >>>  bus_addr_t rather than a bus_size_t.
> >>>  
> >>>  Revision  Changes    Path
> >>>  1.2       +1 -1      src/sys/dev/bce/if_bcereg.h
> >>
> >>Actually, bus_size_t should also be aware of PAE.
> > 
> > That may be true as well, I'll defer to your judgement on that one.  In
> > this case bus_dma_tag_create()'s low_addr argument is supposed to be a
> > bus_addr_t according to the man page. :)
> > 
> 
> Both the lowaddr and highaddr arguments are bus_addr_t.  The more I 
> think about it, the boundary argument should really be a bus_addr_t.

The problem is that PAE's bus_size_t is a 32-bit quantity, when it
should be a 64-bit quantity:

#ifdef PAE
typedef uint64_t bus_addr_t;
#else
typedef uint32_t bus_addr_t;
#endif
typedef uint32_t bus_size_t;

For bus addresses, we should use bus_addr_t, of course, but the above
is wrong.  I don't have a PAE machine, or I'd commit my local changes
that fix this...

Warner