From owner-svn-src-all@freebsd.org Thu Feb 28 00:42:20 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CBA3D150AD2B; Thu, 28 Feb 2019 00:42:19 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DCBDE6A364; Thu, 28 Feb 2019 00:42:18 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: by mail-qk1-f177.google.com with SMTP id y15so11084590qki.8; Wed, 27 Feb 2019 16:42:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hwebM+DdxqXJSrkdrzvNzkHlfBgLyneH0jAZbvTtlEw=; b=mO366rCKZQF5ale/BQMUJWs8FA0kZH6BNasJ8f6my5eHGIV4Ib0tGbkQhQFE9LJB52 +Hpan9to5L9r9HeO2kqQ2+lT4hlYBh9jyjO7P61u2fAfdwzHZQfYoVehnLGzX9SEz+Ca MB+jy8JmlOv6skUrm94i5fWiNy7mM8bYlgxdOuIIKEbCBBCroL7ZENEy1XyZeWwLKhWr tJq5xn+DTIWem3CtKR4w442m+C+hDEYrV8ZCPcOpkBnxm7zxy3vRY/R60Tw9GkYRHxin HCi2fLMuEekJ0jINztG4TAhlt7jofTeaQwbOuOMzXZX4fuI64B/LrQ0qCb5xRiDc1xTU Vgrg== X-Gm-Message-State: AHQUAuboNrLWIXsVf7imLe5dlx2aEIt/R4B2TubnuhhjJnSdLwOTtY5o AFJyB3PM5afS4jnaaLkwamPaKXra/CE= X-Google-Smtp-Source: AHgI3IadgJ5FbMg3ja+PmY2jykdCrIF+vsO/GbE7WBF1BwWiriUEpZES9t7wHTxnEeSi4PDIz8uoag== X-Received: by 2002:a37:4b4e:: with SMTP id y75mr4036155qka.158.1551304759932; Wed, 27 Feb 2019 13:59:19 -0800 (PST) Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com. [209.85.160.178]) by smtp.gmail.com with ESMTPSA id b142sm13623414qka.74.2019.02.27.13.59.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Feb 2019 13:59:19 -0800 (PST) Received: by mail-qt1-f178.google.com with SMTP id s1so21197311qte.5; Wed, 27 Feb 2019 13:59:19 -0800 (PST) X-Received: by 2002:a0c:9e6b:: with SMTP id z43mr3883507qve.131.1551304759479; Wed, 27 Feb 2019 13:59:19 -0800 (PST) MIME-Version: 1.0 References: <201902260928.x1Q9SBp7098439@repo.freebsd.org> <201902261247.x1QClxsH044906@pdx.rh.CN85.dnsmgr.net> <20190226225256.GA31931@stack.nl> In-Reply-To: <20190226225256.GA31931@stack.nl> From: Mateusz Piotrowski <0mp@freebsd.org> Date: Wed, 27 Feb 2019 22:59:06 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r344570 - head/usr.sbin/sysrc To: Jilles Tjoelker Cc: rgrimes@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: DCBDE6A364 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of mpp302@gmail.com designates 209.85.222.177 as permitted sender) smtp.mailfrom=mpp302@gmail.com X-Spamd-Result: default: False [-4.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.91)[-0.907,0]; RCVD_IN_DNSWL_NONE(0.00)[177.222.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.18)[ipnet: 209.85.128.0/17(-3.81), asn: 15169(-2.02), country: US(-0.07)]; FORGED_SENDER(0.30)[0mp@freebsd.org,mpp302@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[177.222.85.209.rep.mailspike.net : 127.0.0.17]; MIME_TRACE(0.00)[0:+,1:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[0mp@freebsd.org,mpp302@gmail.com] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Feb 2019 00:42:20 -0000 On Tue, 26 Feb 2019 at 23:53, Jilles Tjoelker wrote: > On Tue, Feb 26, 2019 at 04:47:59AM -0800, Rodney W. Grimes wrote: > > [ Charset UTF-8 unsupported, converting... ] > > > Author: 0mp (ports committer) > > > Date: Tue Feb 26 09:28:10 2019 > > > New Revision: 344570 > > > URL: https://svnweb.freebsd.org/changeset/base/344570 > > > > Log: > > > sysrc.8: Pet igor and mandoc > > > This only tells the source of why you changed some, > > a good commit log entry tells me that, and what it > > is that you changed. You normally do not need to > > name the file your changed in a commit log as the > > log is attached to the file, sometimes it does make > > since to mention a file name in a log entry when you > > are describing the changes to just that file in a > > commit that includes many files. > > > A better log might of been: > > Pet igor and mandoc. Remove unneeded .Li, use .Fx as needed, > > escape hard stop, and sort cross references. > Alright! Thank you for a review ;) I'll be more precise next time. Naming the affected area, file or directory can be useful to make the > commit message understandable outside of its file's context without > needing to look at the diff or list of changed files. Even better, there > is a convention of making the first line of the commit message a > summary. When following this convention, displaying just the first line > of each commit's message allows a good overview of recent changes in the > whole tree. > I like it as well.