From owner-svn-ports-head@freebsd.org  Thu Dec 24 17:52:12 2015
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 45D44A51AEC;
 Thu, 24 Dec 2015 17:52:12 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "abg.ninja", Issuer "Gandi Standard SSL CA 2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id A94A413B5;
 Thu, 24 Dec 2015 17:52:11 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id 822b98b6
 TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO;
 Thu, 24 Dec 2015 10:52:08 -0700 (MST)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\))
Subject: Re: svn commit: r404326 - head/shells/zsh
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <20151223231402.GF20454@ivaldir.etoilebsd.net>
Date: Thu, 24 Dec 2015 10:52:06 -0700
Cc: Adam Weinberger <adamw@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <1A952F45-D4C6-4039-9FEA-749F0CC58DE8@adamw.org>
References: <201512232256.tBNMukWr007966@repo.freebsd.org>
 <20151223231402.GF20454@ivaldir.etoilebsd.net>
To: Baptiste Daroussin <bapt@FreeBSD.org>
X-Mailer: Apple Mail (2.3112)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Dec 2015 17:52:12 -0000

> On 23 Dec, 2015, at 16:14, Baptiste Daroussin <bapt@FreeBSD.org> =
wrote:
>=20
> On Wed, Dec 23, 2015 at 10:56:46PM +0000, Adam Weinberger wrote:
>> Author: adamw
>> Date: Wed Dec 23 22:56:46 2015
>> New Revision: 404326
>> URL: https://svnweb.freebsd.org/changeset/ports/404326
>>=20
>> Log:
>>  Partially revert r403755. It can't build the curses module against =
ncurses from
>>  ports. It probably can, but configure is too smart to figure that =
out.
>>=20
>>  I have no confidence that linking against curses from ports results =
in a properly
>>  working zshell. So, for now, back out the change. It will build a =
shared lib zsh
>>  against ncurses from ports, but breaks statically-linked zsh's. Mark =
the port
>>  as IGNORE if we're using ncurses from ports and building a static =
zsh.
>>=20
>>  Also, remove a regression-test target that isn't useful anymore =
(thanks to bapt
>>  for the reminder about this).
>>=20
>>  I am not enthused about this change. It doesn't really "fix" the =
below PR, so
>>  much as shoot ourselves in the other foot instead.
>>=20
>>  PR:	205500
>>=20
> The solution is to make --with-term-lib=3D"tinfow tinfo" only when =
building static
> because when building static you will never build the curses module
>=20
> something like --with-term-lib=3D"${TERMLIB}"
> TERMLIB=3D"ncursesw ncurses"
>=20
> then later:
> .if ${PORT_OPTIONS:MSTATIC}
> TERMLIB=3D"tinfow tinfo"
> .endif
>=20
> Which will also fix static building with base the day we split =
libtinfo* from
> libncurses, which would be nice to do in base :)

bapt, you are my hero. Thank you! Committed in r404382.

# Adam


--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org