Date: Wed, 19 Apr 2017 14:24:29 +0200 From: Hans Petter Selasky <hps@selasky.org> To: Cy Schubert <cy@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316811 - head/sys/contrib/ipfilter/netinet Message-ID: <45d50d78-239a-8d9a-286f-310513c3b8a4@selasky.org> In-Reply-To: <201704140513.v3E5Dp7v039091@repo.freebsd.org> References: <201704140513.v3E5Dp7v039091@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04/14/17 07:13, Cy Schubert wrote: > Author: cy > Date: Fri Apr 14 05:13:50 2017 > New Revision: 316811 > URL: https://svnweb.freebsd.org/changeset/base/316811 > > Log: > Add missing free()'s after calls to randomize(). > > PR: NetBSD PR/50559 > Obtained from: Netbsd radix_ipf.c r1.6 > MFC after: 1 week > > Modified: > head/sys/contrib/ipfilter/netinet/radix_ipf.c > > Modified: head/sys/contrib/ipfilter/netinet/radix_ipf.c > ============================================================================== > --- head/sys/contrib/ipfilter/netinet/radix_ipf.c Fri Apr 14 05:12:01 2017 (r316810) > +++ head/sys/contrib/ipfilter/netinet/radix_ipf.c Fri Apr 14 05:13:50 2017 (r316811) > @@ -38,7 +38,7 @@ static void buildnodes __P((addrfamily_t > static ipf_rdx_node_t *ipf_rx_find_addr __P((ipf_rdx_node_t *, u_32_t *)); > static ipf_rdx_node_t *ipf_rx_lookup __P((ipf_rdx_head_t *, addrfamily_t *, > addrfamily_t *)); > -static ipf_rdx_node_t *ipf_rx_match __P((ipf_rdx_head_t *, addrfamily_t *)); > +/* $NetBSD: radix_ipf.c,v 1.6 2015/12/15 12:30:34 christos Exp $ */ > > /* > * Foreword. > @@ -1509,6 +1509,8 @@ random_add(rnh) > add_addr(rnh, i, order[i]); > checktree(rnh); > } > + > + free(order); > } > > > @@ -1526,5 +1528,7 @@ random_delete(rnh) > delete_addr(rnh, i); > checktree(rnh); > } > + > + free(order); > } > #endif /* RDX_DEBUG */ > > I'm seeing this compilation warning: freebsd/sys/contrib/ipfilter/netinet/radix_ipf.c:184: warning: function declaration isn't a prototype [-Wstrict-prototypes] *** [radix_ipf.o] Error code 1 --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?45d50d78-239a-8d9a-286f-310513c3b8a4>