From owner-svn-src-all@FreeBSD.ORG Fri Mar 13 18:14:47 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5F2F4106564A; Fri, 13 Mar 2009 18:14:47 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 2DF4C8FC29; Fri, 13 Mar 2009 18:14:47 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from server.baldwin.cx (pool-98-109-39-197.nwrknj.fios.verizon.net [98.109.39.197]) by cyrus.watson.org (Postfix) with ESMTPSA id CF9B946B0D; Fri, 13 Mar 2009 14:14:46 -0400 (EDT) Received: from new-host-2.baldwin.cx (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.3/8.14.3) with ESMTP id n2DIEfSI061161; Fri, 13 Mar 2009 14:14:41 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: <49BAA2C6.2000807@FreeBSD.org> Date: Fri, 13 Mar 2009 14:15:34 -0400 From: John Baldwin User-Agent: Thunderbird 2.0.0.19 (Macintosh/20081209) MIME-Version: 1.0 To: Konstantin Belousov References: <200812181158.mBIBwC50039690@svn.freebsd.org> In-Reply-To: <200812181158.mBIBwC50039690@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Fri, 13 Mar 2009 14:14:41 -0400 (EDT) X-Virus-Scanned: ClamAV 0.94.2/9105/Fri Mar 13 07:58:59 2009 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r186276 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Mar 2009 18:14:48 -0000 Konstantin Belousov wrote: > Author: kib > Date: Thu Dec 18 11:58:12 2008 > New Revision: 186276 > URL: http://svn.freebsd.org/changeset/base/186276 > > Log: > Do not return success and doomed vnode from lookup. LK_UPGRADE allows > the vnode to be reclaimed. > > Tested by: pho > MFC after: 1 month Would EBADF be more appropriate? That is what other places that check VI_DOOMED return for this type of check (e.g. in cache_lookup()). -- John Baldwin