From owner-p4-projects@FreeBSD.ORG  Wed Dec  8 01:49:17 2004
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 2FE3416A4D0; Wed,  8 Dec 2004 01:49:16 +0000 (GMT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DD46616A4CE
	for <perforce@freebsd.org>; Wed,  8 Dec 2004 01:49:15 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D16C743D1F
	for <perforce@freebsd.org>; Wed,  8 Dec 2004 01:49:15 +0000 (GMT)
	(envelope-from sam@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id iB81nFUm024501
	for <perforce@freebsd.org>; Wed, 8 Dec 2004 01:49:15 GMT
	(envelope-from sam@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id iB81nFd2024498
	for perforce@freebsd.org; Wed, 8 Dec 2004 01:49:15 GMT
	(envelope-from sam@freebsd.org)
Date: Wed, 8 Dec 2004 01:49:15 GMT
Message-Id: <200412080149.iB81nFd2024498@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	sam@freebsd.org using -f
From: Sam Leffler <sam@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 66650 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Dec 2004 01:49:17 -0000

http://perforce.freebsd.org/chv.cgi?CH=66650

Change 66650 by sam@sam_ebb on 2004/12/08 01:48:31

	correct comparison order during ap selection

Affected files ...

.. //depot/projects/wifi/sys/net80211/ieee80211_node.c#25 edit

Differences ...

==== //depot/projects/wifi/sys/net80211/ieee80211_node.c#25 (text+ko) ====

@@ -551,7 +551,7 @@
 	rssia = ic->ic_node_getrssi(a);
 	rssib = ic->ic_node_getrssi(b);
 	if (maxa != maxb && abs(rssib - rssia) < 5)
-		return maxb - maxa;
+		return maxa - maxb;
 
 	/* XXX use freq for channel preference */
 	/* for now just prefer 5Ghz band to all other bands */
@@ -563,7 +563,7 @@
 		return -1;
 
 	/* all things being equal, use signal level */
-	return rssib - rssia;
+	return rssia - rssib;
 }
 
 /*
@@ -683,7 +683,7 @@
 		if (ieee80211_match_bss(ic, ni) == 0) {
 			if (selbs == NULL)
 				selbs = ni;
-			else if (ieee80211_node_compare(ic, ni, selbs) < 0) {
+			else if (ieee80211_node_compare(ic, ni, selbs) > 0) {
 				ieee80211_unref_node(&selbs);
 				selbs = ni;
 			} else