From owner-freebsd-arch@FreeBSD.ORG Sun Feb 19 09:55:28 2012 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5D8591065672; Sun, 19 Feb 2012 09:55:28 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 7A8CE8FC0A; Sun, 19 Feb 2012 09:55:27 +0000 (UTC) Received: by bkcjg1 with SMTP id jg1so5396686bkc.13 for ; Sun, 19 Feb 2012 01:55:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:references:x-comment-to:sender:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=tl5yeoBmbCvJmqfIcdvrMpqlFmiztvar4PmPvp2PgdQ=; b=OfDaafVMzwJerozqarEsl9Sw8Vx3m3XeD54tN4UoP8LP53PYmIDF/zJtIpb5iahr7y Qe7PmsCLWl5gSXf+VfDBdJCPFMQAHFZfQR7q0GXjmMzVrlTAlPfQaeRwKbHBrKsNCMMn KM4dPShPl00geK1ni8AeSLoDQPelhkYgUhZJI= Received: by 10.204.141.11 with SMTP id k11mr7186204bku.5.1329645326254; Sun, 19 Feb 2012 01:55:26 -0800 (PST) Received: from localhost ([95.69.173.122]) by mx.google.com with ESMTPS id jd17sm32575564bkb.4.2012.02.19.01.55.22 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 19 Feb 2012 01:55:24 -0800 (PST) From: Mikolaj Golub To: Konstantin Belousov References: <86sjjobzmn.fsf@kopusha.home.net> <86fwfnti5t.fsf@kopusha.home.net> <20120112215106.GC31224@deviant.kiev.zoral.com.ua> <86hazntwmu.fsf@kopusha.home.net> <20120123031238.GL31224@deviant.kiev.zoral.com.ua> <86zkcfu9ac.fsf@kopusha.home.net> <20120218215003.GM3283@deviant.kiev.zoral.com.ua> X-Comment-To: Konstantin Belousov Sender: Mikolaj Golub Date: Sun, 19 Feb 2012 11:55:20 +0200 In-Reply-To: <20120218215003.GM3283@deviant.kiev.zoral.com.ua> (Konstantin Belousov's message of "Sat, 18 Feb 2012 23:50:03 +0200") Message-ID: <86ehtrf8qf.fsf@kopusha.home.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Robert N. M. Watson" , freebsd-arch@freebsd.org Subject: Re: unix domain sockets on nullfs(5) X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Feb 2012 09:55:28 -0000 On Sat, 18 Feb 2012 23:50:03 +0200 Konstantin Belousov wrote: KB> On Sat, Feb 18, 2012 at 11:22:03PM +0200, Mikolaj Golub wrote: >> After collecting all suggestions and additional testing I have got this patch >> set: >> >> http://people.freebsd.org/~trociny/unp_prepare_reclaim.1.patch KB> Including unpcb.h into vfs_subr.c looks too extreme. Put the prototype KB> into vnode.h, possibly renaming the function to vfs_unp_reclaim. Done. >> http://people.freebsd.org/~trociny/unp_connect.LOCKSHARED.1.patch >> http://people.freebsd.org/~trociny/VOP_UNP.3.patch KB> I has a painting suggestion there, call the vops VOP_UNP_DETACH etc, KB> otherwise it takes too much reading to understand that it is not undetach. Unfortunately, vnode_if.awk does not support underscores in VOP names. It failed with "Invalid %% construction" due to the restriction: $2 !~ /^[a-z]+$/. So I reverted back to the old naming. The updated patches: http://people.freebsd.org/~trociny/unp_prepare_reclaim.2.patch http://people.freebsd.org/~trociny/unp_connect.LOCKSHARED.1.patch http://people.freebsd.org/~trociny/VOP_UNP.4.patch -- Mikolaj Golub