From owner-freebsd-net@FreeBSD.ORG Thu Feb 2 12:58:32 2006 Return-Path: X-Original-To: net@freebsd.org Delivered-To: freebsd-net@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 10CC516A420; Thu, 2 Feb 2006 12:58:32 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5C15943D49; Thu, 2 Feb 2006 12:58:28 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.3/8.13.3) with ESMTP id k12CwO4B005335; Thu, 2 Feb 2006 15:58:25 +0300 (MSK) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.3/8.13.3/Submit) id k12ChT1V003899; Thu, 2 Feb 2006 15:43:29 +0300 (MSK) (envelope-from yar) Date: Thu, 2 Feb 2006 15:43:28 +0300 From: Yar Tikhiy To: Ruslan Ermilov Message-ID: <20060202124328.GK29980@comp.chem.msu.su> References: <20060201005658.A70005@xorpc.icir.org> <20060201090421.GT4297@FreeBSD.org> <20060201103746.GD90360@ip.net.ua> <20060201224939.GB29980@comp.chem.msu.su> <20060202070149.GD18601@ip.net.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060202070149.GD18601@ip.net.ua> User-Agent: Mutt/1.5.9i Cc: Luigi Rizzo , Hajimu UMEMOTO , mlaier@freebsd.org, net@freebsd.org Subject: Re: if_bridge.ko requires INET6... X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Feb 2006 12:58:32 -0000 On Thu, Feb 02, 2006 at 09:01:49AM +0200, Ruslan Ermilov wrote: > On Thu, Feb 02, 2006 at 01:49:40AM +0300, Yar Tikhiy wrote: > > On Wed, Feb 01, 2006 at 12:37:46PM +0200, Ruslan Ermilov wrote: > > > On Wed, Feb 01, 2006 at 06:41:10PM +0900, Hajimu UMEMOTO wrote: > > > > >>>>> On Wed, 1 Feb 2006 12:04:21 +0300 > > > > >>>>> Gleb Smirnoff said: > > > > > > > > glebius> If you have compiled the modules as part of buildkernel > > > > glebius> target, then all options from kernel would apply to all > > > > glebius> modules, thus the bridge_ip6_checkbasic() function won't > > > > glebius> be present in if_bridge.ko, and you would successfully > > > > glebius> load the module. > > > > > > > > I believe it is 7-CURRENT thing, and is not MFCed yet. So, if it is > > > > on 6.x, you need -DNO_INET6 to build if_bridge.ko. > > > > > > > Ask yar@ to MFC his modules/ mega-commit that fixed this in HEAD. > > > I'd really love to see it in 6.1. > > > > I haven't considered that an option since two issues were found > > related to my mega-commit. One was that if_gif wouln't load due > > to unresolved symbols if built w/o INET6. The other was in the > > pf module -- pflog would be lost as it didn't have a separate module. > > > > The essence of the first issue is that the set of source files > > for a module cannot depend on kernel options, unlike for the main > > kernel file. > > > I thought I've fixed it in December (in CVS). I'm running if_gif.ko > without any problems on INET6-less kernel. I missed your commit to the if_gif module. I hope you'll forgive me if I say it is a mere hack, but it will do for now :-) > > The second issue has to do with the fact that pflog is more to > > a plain option than to a device, as there are `#ifdef DEV_PFLOG' > > lines in the pf code conditionalizing the pflog feature. > > > This needs to be fixed in pf then. Max Laier and I discussed this issue once, and Max had concern over possible performance degradation that might result from calling pflog functions through pointers to be set by a separate pflog module. We can skip touching the pf module in RELENG_6 for now and leave the issue to after 6.1-RELEASE is out. -- Yar